From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF7FFC83004 for ; Wed, 29 Apr 2020 13:09:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8EBDC2087E for ; Wed, 29 Apr 2020 13:09:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588165758; bh=T0NAcksnjr9OhtqloV5RFENmLxCHkcX47rWaxgfrR5k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ilUl3E5WHpFO4pRjA3KC/MCP/5DhYu5H3SBrUSAtLgqcz8MLLbHoyhIhY6wa1rIQR yupMXp3x5VG3hmB1rw6ss58cpQTbYX2uLeIvD0m26yzCobQWaRvbOj7T35lkqfN9HZ GmLfhZUQW402XqcuXgXuj7wmy9s3pKDw1OuZ/0oo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726883AbgD2NJR (ORCPT ); Wed, 29 Apr 2020 09:09:17 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:33156 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726516AbgD2NJR (ORCPT ); Wed, 29 Apr 2020 09:09:17 -0400 Received: by mail-wr1-f65.google.com with SMTP id s10so2482962wrr.0 for ; Wed, 29 Apr 2020 06:09:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bH0bbqVQbeUY5It5xqT1zYzIFKuvRYaWvNIr4hXMeAE=; b=A6nT6ZBosg6K9CwrMGA5GRmhDnyzkjMyh1nnsJQlk5h0AOrSQLdnedvujwkJJc/WxC zkAFapclZQ5wCCWOsr3fW7YPqFqxRuZgY1iIqnsta332+xrYNNn4tgD8RyR9PxzQG5na 3BDbJfOazXjIhvirlXHA9FmL0hETLwPj89/waoyZK7uhX1WnyM9ydyn8KkgOA34LyH/X 9S5RLoJsryzUn0/z7RzIrU2TBvYJBEBhsAxSL2dJseBOH4R2Vsbek8aSLy5lBDFsev5P MWc1MaUqjMbWvy1ApHCQWzXHJA/U37UuVp7Zkx0j6ZBkDP+z+btl4wlrgE3KgFUTX3Ug fmvg== X-Gm-Message-State: AGi0PubIpPtkBSSOWFLp2cr2vftJ9AqrsLfVmJ0Fqg9rsf5GQLHAQjD0 dfqpW7wxaPsOLmIe8QCDn1M= X-Google-Smtp-Source: APiQypJkDxrRS6EsgUtBFz8WMEi0Jgs+THobIMxefSCsUFprNNyWNSEjL+uraVhlwtSj/oRYvvDRIQ== X-Received: by 2002:a5d:42cf:: with SMTP id t15mr38561028wrr.354.1588165755294; Wed, 29 Apr 2020 06:09:15 -0700 (PDT) Received: from localhost (ip-37-188-130-62.eurotel.cz. [37.188.130.62]) by smtp.gmail.com with ESMTPSA id n2sm30894945wrq.74.2020.04.29.06.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 06:09:14 -0700 (PDT) Date: Wed, 29 Apr 2020 15:09:12 +0200 From: Michal Hocko To: Maninder Singh Cc: "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , AMIT SAHRAWAT , Vaneet Narang Subject: Re: [PATCH 1/1] mm/vmscan.c: change prototype for shrink_page_list Message-ID: <20200429130912.GE28637@dhcp22.suse.cz> References: <20200429120951.GC28637@dhcp22.suse.cz> <1588139967-19012-1-git-send-email-maninder1.s@samsung.com> <20200429125323epcms5p67a539511c573cd598d78b726503e3204@epcms5p6> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429125323epcms5p67a539511c573cd598d78b726503e3204@epcms5p6> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 29-04-20 18:23:23, Maninder Singh wrote: > > Hi, > > > > >Acked-by: Michal Hocko > > > >Is there any reason to move declarations here? > > > > "unsigned int ret" was changed mistakenely, sending V2. > and "unsigned int nr_reclaimed" is changed to remove hole. Could you be more specific? Have you seen a better stack allocation footprint? -- Michal Hocko SUSE Labs