From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: linux-mips@vger.kernel.org, john.garry@huawei.com,
"Huacai Chen" <chenhc@lemote.com>,
"Paul Burton" <paulburton@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Nathan Chancellor" <natechancellor@gmail.com>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Stephen Kitt" <steve@sk2.org>,
"Serge Semin" <fancer.lancer@gmail.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Anshuman Khandual" <anshuman.khandual@arm.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Daniel Silsby" <dansilsby@gmail.com>,
"Mike Rapoport" <rppt@linux.ibm.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Mark Tomlinson" <mark.tomlinson@alliedtelesis.co.nz>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Allison Randal" <allison@lohutok.net>,
"Tiezhu Yang" <yangtiezhu@loongson.cn>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] MIPS: Massage address spaces headers
Date: Wed, 29 Apr 2020 20:25:05 +0200 [thread overview]
Message-ID: <20200429182505.GB21158@alpha.franken.de> (raw)
In-Reply-To: <7613695F-5A83-4B57-A2E6-0EE27DCF397F@flygoat.com>
On Tue, Apr 28, 2020 at 07:45:19PM +0800, Jiaxun Yang wrote:
>
>
> 于 2020年4月28日 GMT+08:00 下午7:33:26, Thomas Bogendoerfer <tsbogend@alpha.franken.de> 写到:
> >On Tue, Apr 28, 2020 at 10:14:12AM +0800, Jiaxun Yang wrote:
> >> That would allow us modify kernel vm address spaces without
> >> step into the hell of includes.
> >>
> >> Also use some marcos for address spaces to make spaces.h more
> >> clear.
> >>
> >> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> >
> >I don't like this patch as I can't see a good reason for shuffling
> >stuff arround. Can you drop this from this series ?
>
> The problem is without this patch we'll have to include pgtable-32.h and
> pgtable-64.h into asm/io.h, and that will become totally hell.
sure, but this would just mean moving VMALLOC_START, but not the other
stuff in this patch, which is more what I dislike...
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2020-04-29 18:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 2:14 [PATCH v2 0/3] MIPS: Loongson64: Use logic_pio v2 Jiaxun Yang
2020-04-28 2:14 ` [PATCH v2 1/3] MIPS: Massage address spaces headers Jiaxun Yang
2020-04-28 11:33 ` Thomas Bogendoerfer
2020-04-28 11:45 ` Jiaxun Yang
2020-04-29 18:25 ` Thomas Bogendoerfer [this message]
2020-04-28 2:14 ` [PATCH v2 2/3] MIPS: Introduce PCI_IO_VMMAP Jiaxun Yang
2020-04-28 2:14 ` [PATCH v2 3/3] MIPS: Loongson64: Enable PCI_IO_VMMAP Jiaxun Yang
2020-04-28 9:25 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429182505.GB21158@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=akpm@linux-foundation.org \
--cc=allison@lohutok.net \
--cc=anshuman.khandual@arm.com \
--cc=chenhc@lemote.com \
--cc=dansilsby@gmail.com \
--cc=f4bug@amsat.org \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiaxun.yang@flygoat.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mark.tomlinson@alliedtelesis.co.nz \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=paul@crapouillou.net \
--cc=paulburton@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=steve@sk2.org \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®