From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A28C8C83000 for ; Wed, 29 Apr 2020 23:28:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F3F72082E for ; Wed, 29 Apr 2020 23:28:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TBAYO5MM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727089AbgD2X2n (ORCPT ); Wed, 29 Apr 2020 19:28:43 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:41200 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726511AbgD2X2n (ORCPT ); Wed, 29 Apr 2020 19:28:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588202922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JA+x7ivklYOVXi6EM65Qndnld5czyg5MHbUrH8elHXE=; b=TBAYO5MMjC7RL1uJby9HQthYd9/SqOD4SFPHIQuzzdIgCjm80ieN2xx7MI/UJPywqaN6av P12JWHd5MyLfncfqJdfpAvdgzWCv9N6ElFh5A/WE9iM8n1bXI6c4T0LPeYBB6Jm4PBYJEu TGGpPamra27iHutKXudDa2yNL8iO9Jo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-59-hJpvbNOHMrebavxIqqHUJg-1; Wed, 29 Apr 2020 19:28:40 -0400 X-MC-Unique: hJpvbNOHMrebavxIqqHUJg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F2B7A1895A29; Wed, 29 Apr 2020 23:28:38 +0000 (UTC) Received: from treble (ovpn-113-19.rdu2.redhat.com [10.10.113.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F5515D78D; Wed, 29 Apr 2020 23:28:37 +0000 (UTC) Date: Wed, 29 Apr 2020 18:28:35 -0500 From: Josh Poimboeuf To: Arnd Bergmann Cc: Peter Zijlstra , the arch/x86 maintainers , Linux Kernel Mailing List , Kees Cook Subject: Re: Remaining randconfig objtool warnings, linux-next-20200428 Message-ID: <20200429232835.yw6ajtjyleob3lmz@treble> References: <20200428161044.caamvx67t2z4t6vd@treble> <20200429185536.5xshpcwtn4be4llh@treble> <20200429231115.z2mo5bsmrmj4oark@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200429231115.z2mo5bsmrmj4oark@treble> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 29, 2020 at 06:11:15PM -0500, Josh Poimboeuf wrote: > > We can probably move those SYS_NI() instances to kernel/sys_ni.c, > > which does not include the header, but it's still a bit ugly. I'll try > > that tomorrow > > unless you come up with a better suggestion first. > > Oh I guess arm32 doesn't have SYS_NI defined. All this syscall aliasing > stuff is a total mystery to me. Another idea would be to split up syscalls.h into two files: one for SYSCALL_* macros and one for sys_*() function prototypes. It sounds like the latter aren't needed by most header files anyway. * Please note that these prototypes here are only provided for information * purposes, for static analysis, and for linking from the syscall table. * These functions should not be called elsewhere from kernel code. -- Josh