From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8EEFC83001 for ; Thu, 30 Apr 2020 06:21:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBB77214D8 for ; Thu, 30 Apr 2020 06:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588227660; bh=P5A/yyEaB775bJMULnMdqrbUeAoygzWyn5oJcdgrO+A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=sTT+RW0ipS8D1L9LMGCgraa150XZ4aK8Aen60CP2CNNqXheAMl8HeJymkyFvhvvZP hmqlXPEhpHC9YlxAtboxFhcQqgkHepE0Km8aOdLRXxIC8STMwEAUlTp2kv2EFx67x0 avhGfaI/libF/ohJKAOG1Wk4nGrjdZPZYYVKycis= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbgD3GVA (ORCPT ); Thu, 30 Apr 2020 02:21:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:36300 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726337AbgD3GU7 (ORCPT ); Thu, 30 Apr 2020 02:20:59 -0400 Received: from localhost (unknown [122.182.217.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 75BF92082E; Thu, 30 Apr 2020 06:20:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588227659; bh=P5A/yyEaB775bJMULnMdqrbUeAoygzWyn5oJcdgrO+A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zgAbvgC/DfhqtqF/OLvLhG881gSIRSGvh91HtsH8uI4b93lOAWfb3qeVGJF/z9r2L 0jxwae/hJB/GimHy73oUA2X3PhMQjFlzd0UjPk2JAeXNtQhP+QgJKJOjtQWv5rJOzg /d2DTab9H8fENraNmHNmpZ1mbZUC+rXsoCrFLxIY= Date: Thu, 30 Apr 2020 11:50:55 +0530 From: Vinod Koul To: Mathias Nyman Cc: Mathias Nyman , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Yoshihiro Shimoda , Christian Lamparter , John Stultz , Alan Stern , Andreas =?iso-8859-1?Q?B=F6hler?= , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 3/5] usb: xhci: Add support for Renesas controller with memory Message-ID: <20200430062055.GE948789@vkoul-mobl.Dlink> References: <20200424101410.2364219-1-vkoul@kernel.org> <20200424101410.2364219-4-vkoul@kernel.org> <79023293-8ad8-751c-b4ca-8393cdbbf4a2@linux.intel.com> <20200429142850.GM56386@vkoul-mobl.Dlink> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429142850.GM56386@vkoul-mobl.Dlink> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29-04-20, 19:58, Vinod Koul wrote: > On 29-04-20, 16:53, Mathias Nyman wrote: > > On 24.4.2020 13.14, Vinod Koul wrote: > > > /* Prevent runtime suspending between USB-2 and USB-3 initialization */ > > > pm_runtime_get_noresume(&dev->dev); > > > @@ -388,6 +401,9 @@ static void xhci_pci_remove(struct pci_dev *dev) > > > { > > > struct xhci_hcd *xhci; > > > > > > + if (renesas_device) > > > + renesas_xhci_pci_exit(dev); > > > + > > > > Ah, I see, what we really should do is make sure the quirks in the driver data get > > added to xhci->quirks, and then just check for the correct quirk in xhci_pci_remove. > > Ah sure that does sound better, I will update this as well and send an > update with these changes This works for me.. But I have kept the code as in the xhci_pci_probe(), ofcourse removed bool renesas_device. the xhci is not valid before invoking renesas_xhci_check_request_fw(). Is there another way to get xhci from dev without calling usb_hcd_pci_probe(). xhci = hcd_to_xhci(hcd) doesn't seem to work before that! -- ~Vinod