From: Sakari Ailus <sakari.ailus@iki.fi>
To: Daniel Gomez <daniel@qtec.com>
Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [RFC PATCH 1/3] media: v4l2-subdev.h: Add min and max enum
Date: Thu, 30 Apr 2020 12:42:33 +0300 [thread overview]
Message-ID: <20200430094233.GE867@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20200414200151.80089-2-daniel@qtec.com>
Hi Daniel,
Thanks for the patchset.
I'm also cc'ing Laurent who I think could be interested in this one.
On Tue, Apr 14, 2020 at 10:01:49PM +0200, Daniel Gomez wrote:
> Add min and max structures to the v4l2-subdev callback in order to allow
> the subdev to return a range of valid frame intervals.
>
> This would operate similar to the struct v4l2_subdev_frame_size_enum and
> its max and min values for the width and the height. In this case, the
> possibility to return a frame interval range is added to the v4l2-subdev level
> whenever the v4l2 device operates in step-wise or continuous mode.
The current API only allows providing a list of enumerated values. That is
limiting indeed, especially on register list based sensor drivers where
vertical blanking is configurable.
I guess this could be extended to cover what V4L2, more or less. If we tell
it's a range, is it assumed to be contiguous? We don't have try operation
for the frame interval, but I guess set is good enough. The fraction is
probably best for TV standards but it's not what camera sensors natively
use. (But for a register list based driver, the established practice
remains to use frame interval.)
I'm also wondering the effect on existing user space; if a driver gives a
range, how will the existing programs work with such a driver?
I'd add an anonymous union with the interval field, the other field being
min_interval. Then the current applications would get the minimum interval
and still continue to function. I guess compilers are modern enough these
days we can have an anonymous union in the uAPI?
>
> Signed-off-by: Daniel Gomez <daniel@qtec.com>
> ---
> include/uapi/linux/v4l2-subdev.h | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/v4l2-subdev.h b/include/uapi/linux/v4l2-subdev.h
> index 03970ce30741..ee15393c58cd 100644
> --- a/include/uapi/linux/v4l2-subdev.h
> +++ b/include/uapi/linux/v4l2-subdev.h
> @@ -117,6 +117,8 @@ struct v4l2_subdev_frame_interval {
> * @code: format code (MEDIA_BUS_FMT_ definitions)
> * @width: frame width in pixels
> * @height: frame height in pixels
> + * @min_interval: min frame interval in seconds
> + * @max_interval: max frame interval in seconds
> * @interval: frame interval in seconds
> * @which: format type (from enum v4l2_subdev_format_whence)
> */
> @@ -126,9 +128,11 @@ struct v4l2_subdev_frame_interval_enum {
> __u32 code;
> __u32 width;
> __u32 height;
> + struct v4l2_fract min_interval;
> + struct v4l2_fract max_interval;
This changes the memory layout of the struct and breaks the ABI. Any new
fields in the struct may only replace reserved fields while the rest must
stay unchanged.
> struct v4l2_fract interval;
> __u32 which;
> - __u32 reserved[8];
> + __u32 reserved[4];
> };
>
> /**
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2020-04-30 9:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 20:01 [RFC PATCH 0/3] v4l2 api changes for imx378 driver Daniel Gomez
2020-04-14 20:01 ` [RFC PATCH 1/3] media: v4l2-subdev.h: Add min and max enum Daniel Gomez
2020-04-30 9:42 ` Sakari Ailus [this message]
2020-04-30 11:10 ` Laurent Pinchart
2020-04-30 13:31 ` Sakari Ailus
2020-04-30 13:59 ` Laurent Pinchart
2020-04-30 14:15 ` Sakari Ailus
2020-04-30 14:17 ` Laurent Pinchart
2020-04-30 14:18 ` Sakari Ailus
2020-04-30 14:20 ` Laurent Pinchart
2020-04-14 20:01 ` [RFC PATCH 2/3] media: v4l2: Add v4l2 control IDs for temperature Daniel Gomez
2020-04-28 20:15 ` Sakari Ailus
2020-04-14 20:01 ` [RFC PATCH 3/3] media: imx378: Add imx378 camera sensor driver Daniel Gomez
2020-04-28 21:02 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430094233.GE867@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=daniel@qtec.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®