From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BCCEC4724C for ; Thu, 30 Apr 2020 15:26:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6346B2082E for ; Thu, 30 Apr 2020 15:26:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588260416; bh=Gc4CSNIYpNL1Sg9aqBxD4gp1PKP4X9xSXcXPNS+Bx0A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fzaFJGEZPKy72OsDa5SRvKxjzAIKShTbq72WmJwEOQ7TkaB6O6SIirPeeLWpQ6vMk ZEFxQb1uXAHLlDPy4EQ08Pq2xPrFtaJ97yptKMuuthzVivBP7Yc3DsPg39usCrie/j pV/ecG8SeOvsCF5SDQ3LB9u+ByLe8Gx9JuOkDMjY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727850AbgD3P0z (ORCPT ); Thu, 30 Apr 2020 11:26:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:34502 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbgD3P0y (ORCPT ); Thu, 30 Apr 2020 11:26:54 -0400 Received: from localhost (unknown [122.182.217.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8276920731; Thu, 30 Apr 2020 15:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588260414; bh=Gc4CSNIYpNL1Sg9aqBxD4gp1PKP4X9xSXcXPNS+Bx0A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PJ/uIJou43m0kJET6CvgCvR7YIAAP+pe//6F8guEs95z2CUfJ/NDPTQ/9rM4LSFJ0 NbzWBBhknCEV4wj/v/FWMa4RtiuIm5BuD/bTaeo3WesaPVcMZJ1kgJgdM+Hu2u8HSM uJ55r1b03YwOhgpPzxrGfd/0TJyNo6KUx4+CVnJQ= Date: Thu, 30 Apr 2020 20:56:50 +0530 From: Vinod Koul To: Greg Kroah-Hartman Cc: Mathias Nyman , Mathias Nyman , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Christian Lamparter , Yoshihiro Shimoda , John Stultz , Alan Stern , Andreas =?iso-8859-1?Q?B=F6hler?= , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 2/5] usb: renesas-xhci: Add the renesas xhci driver Message-ID: <20200430152650.GK948789@vkoul-mobl.Dlink> References: <20200430101019.1130956-1-vkoul@kernel.org> <20200430101019.1130956-3-vkoul@kernel.org> <8ffd119b-192f-8fcc-46cc-3a405e30338c@linux.intel.com> <20200430144641.GJ948789@vkoul-mobl.Dlink> <20200430145302.GB3495619@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430145302.GB3495619@kroah.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30-04-20, 16:53, Greg Kroah-Hartman wrote: > On Thu, Apr 30, 2020 at 08:16:41PM +0530, Vinod Koul wrote: > > > > diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile > > > > index b191361257cc..c3a79f626393 100644 > > > > --- a/drivers/usb/host/Makefile > > > > +++ b/drivers/usb/host/Makefile > > > > @@ -70,7 +70,8 @@ obj-$(CONFIG_USB_OHCI_HCD_DAVINCI) += ohci-da8xx.o > > > > obj-$(CONFIG_USB_UHCI_HCD) += uhci-hcd.o > > > > obj-$(CONFIG_USB_FHCI_HCD) += fhci.o > > > > obj-$(CONFIG_USB_XHCI_HCD) += xhci-hcd.o > > > > -obj-$(CONFIG_USB_XHCI_PCI) += xhci-pci.o > > > > +usb-xhci-pci-objs := xhci-pci.o xhci-pci-renesas.o > > > > +obj-$(CONFIG_USB_XHCI_PCI) += usb-xhci-pci.o > > > > > > I don't think it's a good idea to rename the xhci-pci module to usb-xhci-pci > > > > > > does > > > > > > xhci-pci-y := xhci-pci.o xhci-pci-renesas.o > > > obj-$(CONFIG_USB_XHCI_PCI) += xhci-pci.o > > > > > > cause some kbuild issues? > > > > Yes with this version I get the warning: > > make[4]: Circular drivers/usb/host/xhci-pci.o <- drivers/usb/host/xhci-pci.o dependency dropped. > > > > I don't speak enough Kbuild, but I guess it does make sense that we have > > xhci-pci.o as target for both xhci-pci.o xhci-pci-renesas.o! That was > > the reason for adding usb tag to this to resolve the conflict. > > > > I am okay for any other mechanism which can work well here. Btw what > > issues do you foresee with adding usb tag to module name. > > It will break all sorts of things. Happens every time we rename > modules, let's not do it unless we absolutely have to. Hmm that is interesting, am not sure why though :) Anyway, I have fixed it up and was able to make both as modules and export two symbols for xhci-pci.ko to use :) Makefile change looks like: +obj-$(CONFIG_USB_XHCI_PCI) += xhci-pci.o xhci-pci-renesas.o Thanks -- ~Vinod