From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5DB2C47253 for ; Fri, 1 May 2020 16:19:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0AB324953 for ; Fri, 1 May 2020 16:19:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730120AbgEAQTT (ORCPT ); Fri, 1 May 2020 12:19:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:36792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728495AbgEAQTS (ORCPT ); Fri, 1 May 2020 12:19:18 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ADC4E2166E; Fri, 1 May 2020 16:19:17 +0000 (UTC) Date: Fri, 1 May 2020 12:19:16 -0400 From: Steven Rostedt To: Josh Poimboeuf Cc: LKML , Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Andy Lutomirski , Borislav Petkov , "H. Peter Anvin" Subject: Re: [RFC][PATCH] x86/ftrace: Have ftrace trampolines turn read-only at the end of system boot up Message-ID: <20200501121916.310942b8@gandalf.local.home> In-Reply-To: <20200501151310.zo5bhnxpu5gubofj@treble> References: <20200430202147.4dc6e2de@oasis.local.home> <20200501044733.eqf6hc6erucsd43x@treble> <20200501051706.4wkrqwovybt2p6hr@treble> <20200501092404.06d1adcb@gandalf.local.home> <20200501151310.zo5bhnxpu5gubofj@treble> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 May 2020 10:13:10 -0500 Josh Poimboeuf wrote: > On Fri, May 01, 2020 at 09:24:04AM -0400, Steven Rostedt wrote: > > On Fri, 1 May 2020 00:17:06 -0500 > > Josh Poimboeuf wrote: > > > > > > Would it be easier to just call a new __text_poke_bp() which skips the > > > > SYSTEM_BOOTING check, since you know the trampoline will always be > > > > read-only? > > > > > > > > Like: > > > > > > early_trace_init() is called after mm_init(), so I thought it might > > > work, but I guess not: > > > > Yeah, I was about to say that this happens before mm_init() ;-) > > It happens *after* mm_init(). But now text_poke() has a dependency on > poking_init(), has a dependency on proc_caches_init(), which has a > dependency on kmem_cache_init_late(), etc. > > So how early do you need early_trace_init()? I'm assuming moving it to > after kmem_cache_init_late() would be too late. People have asked to move it even earlier. The point of having it early is to allow tracing to debug early boot up. > > > It's why we already have magic for enabling function tracing the first time. > > > > Do you see anything wrong with this current solution? It probably needs > > more comments, but I wanted to get acceptance on the logic before I go and > > pretty it up and send a non RFC patch. > > Assuming we can't get text_poke() working earlier, it seems reasonable > to me. > Thanks. Peter, what about you? -- Steve