From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38FE6C47254 for ; Sat, 2 May 2020 13:40:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FE1E21835 for ; Sat, 2 May 2020 13:40:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728023AbgEBNk2 (ORCPT ); Sat, 2 May 2020 09:40:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:39256 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727862AbgEBNk1 (ORCPT ); Sat, 2 May 2020 09:40:27 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DDE6621835; Sat, 2 May 2020 13:40:26 +0000 (UTC) Date: Sat, 2 May 2020 09:40:24 -0400 From: Steven Rostedt To: Changbin Du Cc: Masahiro Yamada , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: Re: [PATCH] streamline_config.pl: add LOCALMODCONFIG_PRESERVE to preserve some kconfigs Message-ID: <20200502094024.6142a04e@oasis.local.home> In-Reply-To: <20200502133054.gx77eoas7u7gnxxm@mail.google.com> References: <20200501023708.108830-1-changbin.du@gmail.com> <20200501130729.3a3e4994@gandalf.local.home> <20200502133054.gx77eoas7u7gnxxm@mail.google.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2 May 2020 21:30:54 +0800 Changbin Du wrote: > > > Sometimes it is useful to preserve batches of configs when making > > > localmodconfig. For example, I usually don't want any usb and fs > > > modules to be disabled. Now we can do it by: > > > > > > $ make LOCALMODCONFIG_PRESERVE="drivers/usb;fs" localmodconfig > > > > That's too much typing ;-) What about just "KEEP='drivers/usb;fs'"? > > > I think we'd better use a long name since it will be passed to the entire kbuild. > And we alreay have one named LOCALMODCONFIG_DEBUG. The prefix LOCALMODCONFIG_ > can help to avoid namespace pollution. I politely disagree. Build options is not common. The LOCALMODCONFIG_DEBUG is an environment variable, which I couldn't just use DEBUG. If you absolutely require a prefix, shorten it to LMC_ or something. I already hate typing 'localmodconfig' once ;-) -- Steve