From: David Miller <davem@davemloft.net>
To: michael@walle.cc
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
f.fainelli@gmail.com, vivien.didelot@gmail.com, andrew@lunn.ch,
claudiu.manoil@nxp.com, vladimir.oltean@nxp.com,
shawnguo@kernel.org
Subject: Re: [PATCH RESEND net-next] net: dsa: felix: allow the device to be disabled
Date: Mon, 04 May 2020 11:16:20 -0700 (PDT) [thread overview]
Message-ID: <20200504.111620.1983042701063972335.davem@davemloft.net> (raw)
In-Reply-To: <20200504165228.12787-1-michael@walle.cc>
From: Michael Walle <michael@walle.cc>
Date: Mon, 4 May 2020 18:52:28 +0200
> If there is no specific configuration of the felix switch in the device
> tree, but only the default configuration (ie. given by the SoCs dtsi
> file), the probe fails because no CPU port has been set. On the other
> hand you cannot set a default CPU port because that depends on the
> actual board using the switch.
>
> [ 2.701300] DSA: tree 0 has no CPU port
> [ 2.705167] mscc_felix 0000:00:00.5: Failed to register DSA switch: -22
> [ 2.711844] mscc_felix: probe of 0000:00:00.5 failed with error -22
>
> Thus let the device tree disable this device entirely, like it is also
> done with the enetc driver of the same SoC.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied, thank you.
prev parent reply other threads:[~2020-05-04 18:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 16:52 Michael Walle
2020-05-04 17:47 ` Vladimir Oltean
2020-05-04 17:48 ` Florian Fainelli
2020-05-04 18:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504.111620.1983042701063972335.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®