mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: x86@kernel.org
Cc: Mike Travis <mike.travis@hpe.com>, linux-kernel@vger.kernel.org
Subject: [PATCH 01/11] x86/uv: Mark uv_bios_call and uv_bios_call_irqsave static
Date: Mon,  4 May 2020 19:15:17 +0200	[thread overview]
Message-ID: <20200504171527.2845224-2-hch@lst.de> (raw)
In-Reply-To: <20200504171527.2845224-1-hch@lst.de>

Both functions are only used inside of bios_uv.c.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/x86/include/asm/uv/bios.h | 6 ------
 arch/x86/platform/uv/bios_uv.c | 9 ++++-----
 2 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/arch/x86/include/asm/uv/bios.h b/arch/x86/include/asm/uv/bios.h
index 389174eaec794..fc85dafa5e496 100644
--- a/arch/x86/include/asm/uv/bios.h
+++ b/arch/x86/include/asm/uv/bios.h
@@ -123,12 +123,6 @@ enum uv_memprotect {
 	UV_MEMPROT_ALLOW_RW
 };
 
-/*
- * bios calls have 6 parameters
- */
-extern s64 uv_bios_call(enum uv_bios_cmd, u64, u64, u64, u64, u64);
-extern s64 uv_bios_call_irqsave(enum uv_bios_cmd, u64, u64, u64, u64, u64);
-
 extern s64 uv_bios_get_sn_info(int, int *, long *, long *, long *, long *);
 extern s64 uv_bios_freq_base(u64, u64 *);
 extern int uv_bios_mq_watchlist_alloc(unsigned long, unsigned int,
diff --git a/arch/x86/platform/uv/bios_uv.c b/arch/x86/platform/uv/bios_uv.c
index c60255da5a6cd..ca287554e2342 100644
--- a/arch/x86/platform/uv/bios_uv.c
+++ b/arch/x86/platform/uv/bios_uv.c
@@ -45,7 +45,8 @@ static s64 __uv_bios_call(enum uv_bios_cmd which, u64 a1, u64 a2, u64 a3,
 	return ret;
 }
 
-s64 uv_bios_call(enum uv_bios_cmd which, u64 a1, u64 a2, u64 a3, u64 a4, u64 a5)
+static s64 uv_bios_call(enum uv_bios_cmd which, u64 a1, u64 a2, u64 a3, u64 a4,
+		u64 a5)
 {
 	s64 ret;
 
@@ -57,10 +58,9 @@ s64 uv_bios_call(enum uv_bios_cmd which, u64 a1, u64 a2, u64 a3, u64 a4, u64 a5)
 
 	return ret;
 }
-EXPORT_SYMBOL_GPL(uv_bios_call);
 
-s64 uv_bios_call_irqsave(enum uv_bios_cmd which, u64 a1, u64 a2, u64 a3,
-					u64 a4, u64 a5)
+static s64 uv_bios_call_irqsave(enum uv_bios_cmd which, u64 a1, u64 a2, u64 a3,
+		u64 a4, u64 a5)
 {
 	unsigned long bios_flags;
 	s64 ret;
@@ -77,7 +77,6 @@ s64 uv_bios_call_irqsave(enum uv_bios_cmd which, u64 a1, u64 a2, u64 a3,
 	return ret;
 }
 
-
 long sn_partition_id;
 EXPORT_SYMBOL_GPL(sn_partition_id);
 long sn_coherency_id;
-- 
2.26.2


  reply	other threads:[~2020-05-04 17:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-04 17:15 x86/uv cleanups Christoph Hellwig
2020-05-04 17:15 ` Christoph Hellwig [this message]
2020-05-07 14:07   ` [tip: x86/platform] x86/platform/uv: Mark uv_bios_call() and uv_bios_call_irqsave() static tip-bot2 for Christoph Hellwig
2020-05-04 17:15 ` [PATCH 02/11] x86/uv: Remove the uv_partition_coherence_id macro Christoph Hellwig
2020-05-07 14:07   ` [tip: x86/platform] x86/platform/uv: Remove the uv_partition_coherence_id() macro tip-bot2 for Christoph Hellwig
2020-05-04 17:15 ` [PATCH 03/11] x86/uv: Unexport sn_coherency_id Christoph Hellwig
2020-05-07 14:07   ` [tip: x86/platform] x86/platform/uv: " tip-bot2 for Christoph Hellwig
2020-05-04 17:15 ` [PATCH 04/11] x86/uv: Unexport symbols only used by x2apic_uv_x.c Christoph Hellwig
2020-05-07 14:07   ` [tip: x86/platform] x86/platform/uv: " tip-bot2 for Christoph Hellwig
2020-05-04 17:15 ` [PATCH 05/11] x86/uv: Remove the UV*_HUB_IS_SUPPORTED macros Christoph Hellwig
2020-05-07 14:07   ` [tip: x86/platform] x86/platform/uv: " tip-bot2 for Christoph Hellwig
2020-05-04 17:15 ` [PATCH 06/11] x86/uv: Mark is_uv_hubless static Christoph Hellwig
2020-05-07 14:07   ` [tip: x86/platform] x86/platform/uv: Mark is_uv_hubless() static tip-bot2 for Christoph Hellwig
2020-05-04 17:15 ` [PATCH 07/11] x86/uv: Mark uv_min_hub_revision_id static Christoph Hellwig
2020-05-07 14:07   ` [tip: x86/platform] x86/platform/uv: " tip-bot2 for Christoph Hellwig
2020-05-04 17:15 ` [PATCH 08/11] x86/uv: Simplify uv_send_IPI_one Christoph Hellwig
2020-05-07 14:07   ` [tip: x86/platform] x86/platform/uv: Simplify uv_send_IPI_one() tip-bot2 for Christoph Hellwig
2020-05-04 17:15 ` [PATCH 09/11] x86/uv: Remove _uv_hub_info_check Christoph Hellwig
2020-05-07 14:07   ` [tip: x86/platform] x86/platform/uv: Remove _uv_hub_info_check() tip-bot2 for Christoph Hellwig
2020-05-04 17:15 ` [PATCH 10/11] x86/uv: Unexport uv_apicid_hibits Christoph Hellwig
2020-05-07 14:07   ` [tip: x86/platform] x86/platform/uv: " tip-bot2 for Christoph Hellwig
2020-05-04 17:15 ` [PATCH 11/11] x86/uv: Remove the unused _uv_cpu_blade_processor_id macro Christoph Hellwig
2020-05-07 14:07   ` [tip: x86/platform] x86/platform/uv: Remove the unused _uv_cpu_blade_processor_id() macro tip-bot2 for Christoph Hellwig
2020-05-05 15:39 ` x86/uv cleanups Dimitri Sivanich
2020-05-05 16:36   ` Andy Lutomirski
2020-05-05 23:14   ` Thomas Gleixner
2020-05-06 21:36     ` Russ Anderson
2020-05-07  4:51       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200504171527.2845224-2-hch@lst.de \
    --to=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.travis@hpe.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®