From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9447C3A5A9 for ; Mon, 4 May 2020 17:22:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A748220752 for ; Mon, 4 May 2020 17:22:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="DuD1Nb41" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730227AbgEDRWQ (ORCPT ); Mon, 4 May 2020 13:22:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729667AbgEDRWO (ORCPT ); Mon, 4 May 2020 13:22:14 -0400 Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA303C061A0F for ; Mon, 4 May 2020 10:22:14 -0700 (PDT) Received: by mail-qv1-xf42.google.com with SMTP id t7so32775qvz.6 for ; Mon, 04 May 2020 10:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pt6BMPXSrsDYj+dLJK8w8jEfMkDpMRpASOQfV9pxQLQ=; b=DuD1Nb41oJ2HpOUKPEnFqwPB6gNTk7Q2NwjNwktIRiUgm1IJirHhqfHquTG0Jaez4d vynHR5wThjgdZMuMfcFMi1Rh9K01b/zmSktWoxHp/EFnCtMdrZdWPC22RN1EbVnPgiiw nqpY4jkc9fqB4vI9qFbH49509NlmuKf/4awQGHWqKcdI/ONwYZBKRMwGbtkR66UT0b86 UVnMiQH0FqTZBnLxuxV1oem9hk6XGScsq7CgR2xeLqxiSUanv1RzNmwV7UqEib7FMq1B jqMBLMI4y106y9vTcM3JzkIsUBshPb9+4dYu/tzU4Jyptj0k1Wv6ZHfFQYRKsWdAivwH kQzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pt6BMPXSrsDYj+dLJK8w8jEfMkDpMRpASOQfV9pxQLQ=; b=XuntJApdLpV95NQ87N5ndVJSAGSKhUp0V4M1HzAQ23LWNpZkH7cAjOWipikTT9nfLz KuBMQ479Bepl+v0noqy55IZnEu0XtF9egxT7Uqzp6JNFVM/QL4Fww0Uj3jwgPoz4fBOh 7tTYE/XxXcN7OWKe61Zhffelg59xmD0LI4ypOCWX65Kgux4zEEIRJWO1tdjynCn8gtCZ 5LdTKvgnnaZrofuMtwkmv4aApSY+PciVh9WnMPfIoKm6AQZDNZUIblxSJ3CXexQ3xLSt nojntS4P+CkaVzvpgJkkpvSwO/ZZQ28cm8yzKgb/egwCZZJL7phO5pQMSVkZYPVjBWZU 1k/A== X-Gm-Message-State: AGi0PuZji2umoFk80XBakQfZRl4fmijz8TO8LiiWFaZxBWj9vhxDO4ir Be/y7YnbSNfEO6JqweaU94Sw8Q== X-Google-Smtp-Source: APiQypJu4BaEU2jCfgY1eS21HQBvDUUbekr9MX/f8cBBw0JVYYC+cyVJZhBw8h+54MXJqAJGtGebJw== X-Received: by 2002:a0c:db87:: with SMTP id m7mr129572qvk.101.1588612933933; Mon, 04 May 2020 10:22:13 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id g1sm1511672qkm.123.2020.05.04.10.22.13 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 May 2020 10:22:13 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jVenE-0004MU-UG; Mon, 04 May 2020 14:22:12 -0300 Date: Mon, 4 May 2020 14:22:12 -0300 From: Jason Gunthorpe To: Sudip Mukherjee Cc: Zhu Yanjun , Doug Ledford , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH v2] RDMA/rxe: check for error Message-ID: <20200504172212.GA16728@ziepe.ca> References: <20200425233545.17210-1-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200425233545.17210-1-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 26, 2020 at 12:35:45AM +0100, Sudip Mukherjee wrote: > The commit 'ff23dfa13457' modified rxe_create_mmap_info() to return > error code and also NULL but missed fixing codes which called > rxe_create_mmap_info(). Modify rxe_create_mmap_info() to only return > errorcode and fix error checking after rxe_create_mmap_info() was > called. > > Fixes: ff23dfa13457 ("IB: Pass only ib_udata in function prototypes") > Cc: stable@vger.kernel.org [5.4+] > Signed-off-by: Sudip Mukherjee > Signed-off-by: Sudip Mukherjee > --- > drivers/infiniband/sw/rxe/rxe_mmap.c | 2 +- > drivers/infiniband/sw/rxe/rxe_queue.c | 6 ++++-- > 2 files changed, 5 insertions(+), 3 deletions(-) Applied to for-rc, thanks Jason