From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 417D4C47247 for ; Tue, 5 May 2020 18:12:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C7AF206FA for ; Tue, 5 May 2020 18:12:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730819AbgEESMP (ORCPT ); Tue, 5 May 2020 14:12:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729663AbgEESMO (ORCPT ); Tue, 5 May 2020 14:12:14 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE456C061A0F; Tue, 5 May 2020 11:12:14 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8D08A127EDD2C; Tue, 5 May 2020 11:12:10 -0700 (PDT) Date: Tue, 05 May 2020 11:12:06 -0700 (PDT) Message-Id: <20200505.111206.118627398774406136.davem@davemloft.net> To: zhengdejin5@gmail.com Cc: swboyd@chromium.org, ynezz@true.cz, netdev@vger.kernel.org, jonathan.richardson@broadcom.com, linux-kernel@vger.kernel.org, scott.branden@broadcom.com, ray.jui@broadcom.com, f.fainelli@gmail.com Subject: Re: [PATCH net v1] net: broadcom: fix a mistake about ioremap resource From: David Miller In-Reply-To: <20200505020329.31638-1-zhengdejin5@gmail.com> References: <20200505020329.31638-1-zhengdejin5@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 May 2020 11:12:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dejin Zheng Date: Tue, 5 May 2020 10:03:29 +0800 > Commit d7a5502b0bb8b ("net: broadcom: convert to > devm_platform_ioremap_resource_byname()") will broke this driver. > idm_base and nicpm_base were optional, after this change, they are > mandatory. it will probe fails with -22 when the dtb doesn't have them > defined. so revert part of this commit and make idm_base and nicpm_base > as optional. > > Fixes: d7a5502b0bb8bde ("net: broadcom: convert to devm_platform_ioremap_resource_byname()") > Reported-by: Jonathan Richardson > Signed-off-by: Dejin Zheng Applied, thank you.