From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E22DC47254 for ; Tue, 5 May 2020 08:05:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B7EB206B9 for ; Tue, 5 May 2020 08:05:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="vVwV1Qr/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728378AbgEEIE7 (ORCPT ); Tue, 5 May 2020 04:04:59 -0400 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]:65368 "EHLO smtp-fw-6001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726337AbgEEIE6 (ORCPT ); Tue, 5 May 2020 04:04:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1588665898; x=1620201898; h=from:to:cc:subject:date:message-id:in-reply-to: mime-version; bh=tbHmaPqCZ2rJJARJTMpr1HfWh6PkblrvobCFVMdGHiA=; b=vVwV1Qr/kd71NHeC74cXkC82Wh8TR+AzKmISRFlVZ5b9rRsCzyUjgLQb 44AKBLadggO+7geIDv40IPTxqt2Sd5HhmjpHF/I3+rKYvPejDONRJKwdF zQEJ9RN3DgH+b4VMVisRI1DwbLhBVhwRK7pgeM9PxBLSNu9uGnp1ucTKw E=; IronPort-SDR: /CWxTVl4jK6AL1c7zLUXB6EOIyiW4v7Rh/LUnxTiV47KjtaF+zj4VwZmnthSJWAYhgLUgR6gcz cXSpTKp3r0Dw== X-IronPort-AV: E=Sophos;i="5.73,354,1583193600"; d="scan'208";a="30083670" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2c-1968f9fa.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP; 05 May 2020 08:04:57 +0000 Received: from EX13MTAUEA002.ant.amazon.com (pdx4-ws-svc-p6-lb7-vlan3.pdx.amazon.com [10.170.41.166]) by email-inbound-relay-2c-1968f9fa.us-west-2.amazon.com (Postfix) with ESMTPS id E544EA07B3; Tue, 5 May 2020 08:04:55 +0000 (UTC) Received: from EX13D31EUA001.ant.amazon.com (10.43.165.15) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 5 May 2020 08:04:54 +0000 Received: from u886c93fd17d25d.ant.amazon.com (10.43.160.180) by EX13D31EUA001.ant.amazon.com (10.43.165.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 5 May 2020 08:04:49 +0000 From: SeongJae Park To: Greg KH CC: SeongJae Park , , , , , , , SeongJae Park Subject: Re: Re: [PATCH net 1/2] Revert "coallocate socket_wq with socket itself" Date: Tue, 5 May 2020 10:04:34 +0200 Message-ID: <20200505080434.5651-1-sjpark@amazon.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200505074511.GA4054974@kroah.com> (raw) MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.43.160.180] X-ClientProxiedBy: EX13D06UWA002.ant.amazon.com (10.43.160.143) To EX13D31EUA001.ant.amazon.com (10.43.165.15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 May 2020 09:45:11 +0200 Greg KH wrote: > On Tue, May 05, 2020 at 09:28:40AM +0200, SeongJae Park wrote: > > From: SeongJae Park > > > > This reverts commit 333f7909a8573145811c4ab7d8c9092301707721. > > > > The commit 6d7855c54e1e ("sockfs: switch to ->free_inode()") made the > > deallocation of 'socket_alloc' to be done asynchronously using RCU, as > > same to 'sock.wq'. And the following commit 333f7909a857 ("coallocate > > socket_sq with socket itself") made those to have same life cycle. > > > > The changes made the code much more simple, but also made 'socket_alloc' > > live longer than before. For the reason, user programs intensively > > repeating allocations and deallocations of sockets could cause memory > > pressure on recent kernels. > > > > To avoid the problem, this commit separates the life cycle of > > 'socket_alloc' and 'sock.wq' again. The following commit will make the > > deallocation of 'socket_alloc' to be done synchronously again. > > --- > > No signed-off-by? > No "Fixes:"? Oops, my mistake. I will post next version right now. Thanks, SeongJae Park > > :(