From: Andrew Morton <akpm@linux-foundation.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
linux-kernel@vger.kernel.org, users@linux.kernel.org
Subject: Re: [PATCH v2] checkpatch: use patch subject when reading from stdin
Date: Tue, 5 May 2020 12:18:05 -0700 [thread overview]
Message-ID: <20200505121805.cb29ea992ec3e3b445f4b707@linux-foundation.org> (raw)
In-Reply-To: <20200505132613.17452-1-geert+renesas@glider.be>
On Tue, 5 May 2020 15:26:13 +0200 Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> While "git am" can apply an mbox file containing multiple patches (e.g.
> as created by b4[1], or a patch bundle downloaded from patchwork),
> checkpatch does not have proper support for that. When operating on an
> mbox, checkpatch will merge all detected tags, and complain falsely
> about duplicates:
>
> WARNING: Duplicate signature
>
> As modifying checkpatch to reset state in between each patch is a lot of
> work, a simple solution is splitting the mbox into individual patches,
> and invoking checkpatch for each of them. Fortunately checkpatch can read
> a patch from stdin, so the classic "formail" tool can be used to split
> the mbox, and pipe all individual patches to checkpatch:
>
> formail -s scripts/checkpatch.pl < my-mbox
>
> However, when reading a patch file from standard input, checkpatch calls
> it "Your patch", and reports its state as:
>
> Your patch has style problems, please review.
>
> or:
>
> Your patch has no obvious style problems and is ready for submission.
Showing the proposed "after patch" output would be helpful. It seems
that it will be
"checkpatch: use patch subject when reading from stdin" has no obvious style problems and is ready for submission.
yes?
> Hence it can be difficult to identify which patches need to be reviewed
> and improved.
>
> Fix this by replacing "Your patch" by (the first line of) the email
> subject, if present.
>
> Note that "git mailsplit" can also be used to split an mbox, but it will
> create individual files for each patch, thus requiring cleanup
> afterwards. Formail does not have this disadvantage.
>
next prev parent reply other threads:[~2020-05-05 19:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 13:26 Geert Uytterhoeven
2020-05-05 19:18 ` Andrew Morton [this message]
2020-05-06 6:55 ` Geert Uytterhoeven
2020-05-05 19:57 ` Joe Perches
2020-05-05 20:40 ` [kernel.org users] " Pali Rohár
2020-05-05 20:54 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505121805.cb29ea992ec3e3b445f4b707@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=geert+renesas@glider.be \
--cc=joe@perches.com \
--cc=konstantin@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=users@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®