From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17A00C28CBC for ; Wed, 6 May 2020 10:35:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E120120663 for ; Wed, 6 May 2020 10:35:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729212AbgEFKfK (ORCPT ); Wed, 6 May 2020 06:35:10 -0400 Received: from mail.secom.com.pl ([213.216.87.26]:54526 "EHLO mail.secom.com.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728943AbgEFKfJ (ORCPT ); Wed, 6 May 2020 06:35:09 -0400 Received: from debian-2019.secom.com.pl ([192.168.192.41]) by mail.secom.com.pl; Wed, 06 May 2020 12:34:46 +0200 From: =?UTF-8?q?Rafa=C5=82=20Hibner?= Cc: =?UTF-8?q?Rafa=C5=82=20Hibner?= , Appana Durga Kedareswara rao , Radhey Shyam Pandey , Harini Katakam , Vinod Koul , Dan Williams , Michal Simek , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH V2] dma: zynqmp_dma: Move list_del inside zynqmp_dma_free_descriptor. Date: Wed, 6 May 2020 12:28:45 +0200 Message-Id: <20200506102844.2259-1-rafal.hibner@secom.com.pl> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org List elements are not formally removed from list during zynqmp_dma_reset. Signed-off-by: Rafal Hibner --- > Looking at this, i think it would make sense to do list_splice_init() before we > send the list to be freed. Moving list_del inside zynqmp_dma_free_descriptor fixes the problem just as well and avoids INIT_LIST_HEAD(list). I still don't see how list_splice_init would help here. Regards, Rafal --- drivers/dma/xilinx/zynqmp_dma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c index 931e41a72..df0403335 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -434,6 +434,7 @@ static void zynqmp_dma_free_descriptor(struct zynqmp_dma_chan *chan, struct zynqmp_dma_desc_sw *child, *next; chan->desc_free_cnt++; + list_del(&sdesc->node); list_add_tail(&sdesc->node, &chan->free_list); list_for_each_entry_safe(child, next, &sdesc->tx_list, node) { chan->desc_free_cnt++; @@ -604,8 +605,6 @@ static void zynqmp_dma_chan_desc_cleanup(struct zynqmp_dma_chan *chan) dma_async_tx_callback callback; void *callback_param; - list_del(&desc->node); - callback = desc->async_tx.callback; callback_param = desc->async_tx.callback_param; if (callback) { -- 2.20.1