From: Grygorii Strashko <grygorii.strashko@ti.com>
To: "David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
Tero Kristo <t-kristo@ti.com>
Cc: <netdev@vger.kernel.org>, Sekhar Nori <nsekhar@ti.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Rob Herring <robh@kernel.org>
Subject: [PATCH net-next 2/3] dt-binding: net: ti: am65x-cpts: make reg and compatible required
Date: Wed, 6 May 2020 21:14:00 +0300 [thread overview]
Message-ID: <20200506181401.28699-3-grygorii.strashko@ti.com> (raw)
In-Reply-To: <20200506181401.28699-1-grygorii.strashko@ti.com>
This patch follows K3 CPTS review comments from Rob Herring
<robh@kernel.org>.
- "reg" and "compatible" properties are required now
- minor format changes
- K3 CPTS example added to K3 MCU CPSW bindings
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
.../bindings/net/ti,k3-am654-cpsw-nuss.yaml | 15 ++++++++++-
.../bindings/net/ti,k3-am654-cpts.yaml | 25 +++++++------------
2 files changed, 23 insertions(+), 17 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
index 0c054a2ce5ba..c87395f360a6 100644
--- a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
+++ b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
@@ -144,7 +144,7 @@ patternProperties:
description:
CPSW MDIO bus.
- "^cpts$":
+ "^cpts@[0-9a-f]+":
type: object
allOf:
- $ref: "ti,k3-am654-cpts.yaml#"
@@ -171,6 +171,8 @@ examples:
#include <dt-bindings/pinctrl/k3.h>
#include <dt-bindings/soc/ti,sci_pm_domain.h>
#include <dt-bindings/net/ti-dp83867.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
mcu_cpsw: ethernet@46000000 {
compatible = "ti,am654-cpsw-nuss";
@@ -229,4 +231,15 @@ examples:
ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
};
};
+
+ cpts@3d000 {
+ compatible = "ti,am65-cpts";
+ reg = <0x0 0x3d000 0x0 0x400>;
+ clocks = <&k3_clks 18 2>;
+ clock-names = "cpts";
+ interrupts-extended = <&gic500 GIC_SPI 858 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "cpts";
+ ti,cpts-ext-ts-inputs = <4>;
+ ti,cpts-periodic-outputs = <2>;
+ };
};
diff --git a/Documentation/devicetree/bindings/net/ti,k3-am654-cpts.yaml b/Documentation/devicetree/bindings/net/ti,k3-am654-cpts.yaml
index df83c320e61b..50e027911dd4 100644
--- a/Documentation/devicetree/bindings/net/ti,k3-am654-cpts.yaml
+++ b/Documentation/devicetree/bindings/net/ti,k3-am654-cpts.yaml
@@ -42,7 +42,7 @@ description: |+
properties:
$nodename:
- pattern: "^cpts(@.*|-[0-9a-f])*$"
+ pattern: "^cpts@[0-9a-f]+$"
compatible:
oneOf:
@@ -52,7 +52,7 @@ properties:
reg:
maxItems: 1
description:
- The physical base address and size of CPTS IO range
+ The physical base address and size of CPTS IO range
reg-names:
items:
@@ -65,27 +65,27 @@ properties:
items:
- const: cpts
- interrupts-extended:
+ interrupts:
items:
- description: CPTS events interrupt
interrupt-names:
items:
- - const: "cpts"
+ - const: cpts
ti,cpts-ext-ts-inputs:
allOf:
- $ref: /schemas/types.yaml#/definitions/uint32
maximum: 8
description:
- Number of hardware timestamp push inputs (HWx_TS_PUSH)
+ Number of hardware timestamp push inputs (HWx_TS_PUSH)
ti,cpts-periodic-outputs:
allOf:
- $ref: /schemas/types.yaml#/definitions/uint32
maximum: 8
description:
- Number of timestamp Generator function outputs (TS_GENFx)
+ Number of timestamp Generator function outputs (TS_GENFx)
refclk-mux:
type: object
@@ -107,9 +107,11 @@ properties:
- clocks
required:
+ - compatible
+ - reg
- clocks
- clock-names
- - interrupts-extended
+ - interrupts
- interrupt-names
additionalProperties: false
@@ -140,13 +142,4 @@ examples:
assigned-clock-parents = <&k3_clks 118 11>;
};
};
- - |
- cpts {
- clocks = <&k3_clks 18 2>;
- clock-names = "cpts";
- interrupts-extended = <&gic500 GIC_SPI 858 IRQ_TYPE_LEVEL_HIGH>;
- interrupt-names = "cpts";
- ti,cpts-ext-ts-inputs = <4>;
- ti,cpts-periodic-outputs = <2>;
- };
--
2.17.1
next prev parent reply other threads:[~2020-05-06 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 18:13 [PATCH net-next 0/3] net: ethernet: ti: am65x-cpts: follow up dt bindings update Grygorii Strashko
2020-05-06 18:13 ` [PATCH net-next 1/3] net: ethernet: ti: am65-cpsw-nuss: use of_platform_device_create() for mdio Grygorii Strashko
2020-05-06 18:14 ` Grygorii Strashko [this message]
2020-05-06 18:14 ` [PATCH net-next 3/3] arm64: dts: ti: k3-am65/j721e-mcu: update cpts node Grygorii Strashko
2020-05-08 0:51 ` [PATCH net-next 0/3] net: ethernet: ti: am65x-cpts: follow up dt bindings update David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506181401.28699-3-grygorii.strashko@ti.com \
--to=grygorii.strashko@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®