From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D2EBC28CBC for ; Wed, 6 May 2020 19:37:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE6912076D for ; Wed, 6 May 2020 19:37:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588793836; bh=d8kE2FciPli87V4YhQ7IP/bZuwFccaqkbZSCbAm8Y6Q=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:List-ID: From; b=oTqwJWHXzfThICt0ivUn/sQzgIA4lvXEI05ip39JnJzwc9r0Uw6dMyt5hHvHmnjNB lg3kynIg1IgMg70DMVWhmma7kdklsGF+mRTJ1/12wspQvnxRktCoTz+Xl8yZZL2xzb u3I3IfMCmqHqyQGKLqJzyNPs6gZALPkwsAhcZA/4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729271AbgEFThP (ORCPT ); Wed, 6 May 2020 15:37:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:60782 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729251AbgEFThO (ORCPT ); Wed, 6 May 2020 15:37:14 -0400 Received: from paulmck-ThinkPad-P72.home (50-39-105-78.bvtn.or.frontiernet.net [50.39.105.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C800820747; Wed, 6 May 2020 19:37:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588793833; bh=d8kE2FciPli87V4YhQ7IP/bZuwFccaqkbZSCbAm8Y6Q=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=thcdmZvmQwIDx//g+mvuHeTTue5JJr6n/LIDsH9WiS4Hg/gFXppnoX0mBBgkMjhSL poKkUlSEgSC8qUJsKND4AffcYB60IGCctWzWKU9J2SGLPRSb97MdhtBDmrvH0//HJo zFNOA6+erlv1asGrINlrLMRSChBCEGTcrUcX1jho= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id AAF8D35230A1; Wed, 6 May 2020 12:37:13 -0700 (PDT) Date: Wed, 6 May 2020 12:37:13 -0700 From: "Paul E. McKenney" To: Marco Elver Cc: Will Deacon , Ingo Molnar , Thomas Gleixner , Peter Zijlstra , LKML Subject: Re: Please can I have a stable KCSAN branch for 5.8? Message-ID: <20200506193713.GG2869@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20200506132816.GJ8043@willie-the-truck> <20200506143616.GY2869@paulmck-ThinkPad-P72> <20200506144141.GA12919@willie-the-truck> <20200506180232.GB2869@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 06, 2020 at 09:11:23PM +0200, Marco Elver wrote: > On Wed, 6 May 2020 at 20:02, Paul E. McKenney wrote: > > > > On Wed, May 06, 2020 at 05:26:56PM +0200, Marco Elver wrote: > > > On Wed, 6 May 2020 at 16:41, Will Deacon wrote: > > > > > > > > Hi Paul, > > > > > > > > Cheers for the quick reply! > > > > > > > > On Wed, May 06, 2020 at 07:36:16AM -0700, Paul E. McKenney wrote: > > > > > On Wed, May 06, 2020 at 02:28:17PM +0100, Will Deacon wrote: > > > > > > I'm looking to rebase my READ_ONCE() series [1] on top of the KCSAN patches > > > > > > so that we can get them in for 5.8. However, tip/locking/kcsan seems to be > > > > > > missing some bits: > > > > > > > > > > > > * An update to checkpatch.pl to warn about missing comments for > > > > > > data_race(): > > > > > > > > > > > > https://lore.kernel.org/r/20200401101714.44781-1-elver@google.com > > > > > > > > > > For some reason, I thought this was going up some other tree, but I do > > > > > not see it in -next. So unless I hear otherwise, I will pull it into > > > > > the v5.8 kcsan branch. > > > > > > > > Brill, thanks. > > > > > > > > > > * I'm unable to apply these two patches from Marco that are needed for > > > > > > my READ_ONCE() work: > > > > > > > > > > > > https://lore.kernel.org/lkml/20200424154730.190041-1-elver@google.com/ > > > > > > > > > > > > I think these depend on stuff that has been queued by Paul, and appears > > > > > > in linux-next, but to be honest with you I'm quite confused about what > > > > > > is queued for 5.8 and what isn't. > > > > > > > > > > This one is queued, but I currently have it in the v5.9 pile (but > > > > > tentatively for v5.8). Unless Marco tells me otherwise, I will move it > > > > > to the v5.8 branch, which will be part of my pull request next week. > > > > > > > > Great, then this would all show up on tip/locking/kscan, right? > > > > > > > > > > What's the best base for me to use? > > > > > > > > > > The -next tree has the latter, but not yet the former. > > > > > > > > That probably means -next is good enough for me to cook a new version of my > > > > series, and then I can make a proper branch next week. > > > > > > > > > Hopefully we can get this straightened out, and please accept my apologies > > > > > for the hassle! > > > > > > > > No need to apologise, I just couldn't figure out what was what and decided > > > > it was easier to ask the experts ;) > > > > > > Just confirming that I don't see any issues with the plan -- the > > > patches that Will needs are good to go into the v5.8 branch. > > > > OK, I have updated -rcu's kcsan and kcsan-dev branches. Could you please > > double-check, given that pull-request time is quite soon? > > I believe "objtool, kcsan: Add kcsan_disable_current() and > kcsan_enable_current_nowarn()" is missing, which should go after > "kcsan: Add __kcsan_{enable,disable}_current() variants". Thank you for checking! I will move that one also. Thanx, Paul