From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA47C38A24 for ; Thu, 7 May 2020 11:43:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F16F420735 for ; Thu, 7 May 2020 11:43:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726825AbgEGLn0 (ORCPT ); Thu, 7 May 2020 07:43:26 -0400 Received: from elvis.franken.de ([193.175.24.41]:43588 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726572AbgEGLnV (ORCPT ); Thu, 7 May 2020 07:43:21 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jWevq-00081e-04; Thu, 07 May 2020 13:43:14 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 952AEC0409; Thu, 7 May 2020 13:10:07 +0200 (CEST) Date: Thu, 7 May 2020 13:10:07 +0200 From: Thomas Bogendoerfer To: Sergey.Semin@baikalelectronics.ru Cc: Ralf Baechle , Markos Chandras , Serge Semin , Alexey Malahov , Paul Burton , Arnd Bergmann , Rob Herring , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, Allison Randal , Greg Kroah-Hartman , Thomas Gleixner , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 04/20] mips: cm: Fix an invalid error code of INTVN_*_ERR Message-ID: <20200507111007.GE11616@alpha.franken.de> References: <20200306124807.3596F80307C2@mail.baikalelectronics.ru> <20200506174238.15385-1-Sergey.Semin@baikalelectronics.ru> <20200506174238.15385-5-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200506174238.15385-5-Sergey.Semin@baikalelectronics.ru> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 06, 2020 at 08:42:22PM +0300, Sergey.Semin@baikalelectronics.ru wrote: > From: Serge Semin > > Commit 3885c2b463f6 ("MIPS: CM: Add support for reporting CM cache > errors") adds cm2_causes[] array with map of error type ID and > pointers to the short description string. There is a mistake in > the table, since according to MIPS32 manual CM2_ERROR_TYPE = {17,18} > correspond to INTVN_WR_ERR and INTVN_RD_ERR, while the table > claims they have {0x17,0x18} codes. This is obviously hex-dec > copy-paste bug. Moreover codes {0x18 - 0x1a} indicate L2 ECC errors. > > Fixes: 3885c2b463f6 ("MIPS: CM: Add support for reporting CM cache errors") > Signed-off-by: Serge Semin > Cc: Alexey Malahov > Cc: Thomas Bogendoerfer > Cc: Paul Burton > Cc: Ralf Baechle > Cc: Arnd Bergmann > Cc: Rob Herring > Cc: linux-pm@vger.kernel.org > Cc: devicetree@vger.kernel.org > --- > arch/mips/kernel/mips-cm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]