From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12D7FC38A24 for ; Thu, 7 May 2020 15:51:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBA9D2082E for ; Thu, 7 May 2020 15:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588866695; bh=1Q9VbK+JcufVG88INJmlPCjfx0C7wnoXRYXdD54VdV4=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=QWg0HIkQWy/9M15lrCsYolmSB31Uz5KLe+00pxRMX0RU5p0XpJP7FQerUJN449y3i iYbvl0KNmWrNmihgTEY3Al2ECepFVID9pamgxGQkVKeqLvp2L2OailGGILIldKsJIk zfrXIEtAvcTR9J2UJNYJCQu7jhcH8x4v1aKeQ5C4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727779AbgEGPvf (ORCPT ); Thu, 7 May 2020 11:51:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:38404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726616AbgEGPve (ORCPT ); Thu, 7 May 2020 11:51:34 -0400 Received: from localhost (mobile-166-175-190-200.mycingular.net [166.175.190.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF54A20659; Thu, 7 May 2020 15:51:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588866694; bh=1Q9VbK+JcufVG88INJmlPCjfx0C7wnoXRYXdD54VdV4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=O+QfpX/C/690T6tqapb1Dd6Z+sXEs6NySD2jiIFxIhM8Z49iD9rw38Bq/MHy20Hei Zi3pj6HAmRMao3K0gj1TyLUXXkd7Io3IbAOJDl52KIsXbq5EH9DOMpbDSLtPY5CNwq EZYjY5AUJ1K/7Mmfxx7Kq3iTaaq76DdczroJyJBI= Date: Thu, 7 May 2020 10:51:32 -0500 From: Bjorn Helgaas To: Niklas Schnelle Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Pierre Morel , Peter Oberparleiter Subject: Re: [RFC 1/2] PCI/IOV: Introduce pci_iov_sysfs_link() function Message-ID: <20200507155132.GA6568@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 07, 2020 at 09:48:30AM +0200, Niklas Schnelle wrote: > On 5/6/20 11:10 PM, Bjorn Helgaas wrote: > > On Wed, May 06, 2020 at 05:41:38PM +0200, Niklas Schnelle wrote: > >> currently pci_iov_add_virtfn() scans the SR-IOV bars, adds the VF to the > >> bus and also creates the sysfs links between the newly added VF and its > >> parent PF. > > > > s/currently/Currently/ > > s/bars/BARs/ > > > >> With pdev->no_vf_scan fencing off the entire pci_iov_add_virtfn() call > >> s390 as the sole pdev->no_vf_scan user thus ends up missing these sysfs > >> links which are required for example by QEMU/libvirt. > >> Instead of duplicating the code introduce a new pci_iov_sysfs_link() > >> function for establishing sysfs links. > > > > This looks like two paragraphs missing the blank line between. > > > > This whole thing is not "introducing" any new functionality; it's > > "refactoring" to move existing functionality around and make it > > callable separately. > You're right I'll keep it in the subject for easier reference > if that's okay with you. > > > >> Signed-off-by: Niklas Schnelle > > > > With the fixes above and a few below: > > > > Acked-by: Bjorn Helgaas > > Thank you for the very quick and useful feedback. > I've incorporated the changes and will resend with the PATCH prefix. > If/when accepted what tree should the first patch go to? I'd expect them both to go via the s390 tree so there's no dependency between the PCI merge and the s390 merge. > And yes I plan to let the second patch go via the s390 tree.