From: Zhen Lei <thunder.leizhen@huawei.com>
To: David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH v2 1/1] mm/page_io.c: remove an unnecessary goto in generic_swapfile_activate()
Date: Fri, 8 May 2020 20:06:40 +0800 [thread overview]
Message-ID: <20200508120640.1852-2-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <20200508120640.1852-1-thunder.leizhen@huawei.com>
This "goto" doesn't reduce any code, but bother the readers.
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
mm/page_io.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/page_io.c b/mm/page_io.c
index 76965be1d40e..19d429abb2cc 100644
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -237,8 +237,7 @@ int generic_swapfile_activate(struct swap_info_struct *sis,
return ret;
bad_bmap:
pr_err("swapon: swapfile has holes\n");
- ret = -EINVAL;
- goto out;
+ return -EINVAL;
}
/*
--
2.26.0.106.g9fadedd
prev parent reply other threads:[~2020-05-08 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 12:06 [PATCH v2 0/1] " Zhen Lei
2020-05-08 12:06 ` Zhen Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508120640.1852-2-thunder.leizhen@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®