From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9B72C47255 for ; Fri, 8 May 2020 17:36:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83E56218AC for ; Fri, 8 May 2020 17:36:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588959374; bh=hRqx7QnwUzVVyfLcYGbbO44yyAmWkryLH6lR1hltF6s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=FJ1Yo/pJ+iAIP1rBsjggTz3WoHR3n5DdLqP28FRje52Xkozv0q+3BchJ6el9wQyP3 /XhutEsLoVsy7tS4cl4jzjaj64xPNi0bzoZsYu8Jij5o5HmINvMu9JRX/x11t+xo74 jqH5cS+M0O2COPlNMKMKC24roIZwVL82Ro5kG8rI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727088AbgEHRgN (ORCPT ); Fri, 8 May 2020 13:36:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:36074 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726767AbgEHRgN (ORCPT ); Fri, 8 May 2020 13:36:13 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C62162184D; Fri, 8 May 2020 17:36:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588959372; bh=hRqx7QnwUzVVyfLcYGbbO44yyAmWkryLH6lR1hltF6s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mu1u/yVegzhbRrgAnzmV32ElFBUzj2NSItbfkVO2f9Ki1cUZQTMkEUKZZAgWmR+Kg +2eiaX7rpB6B4k3uA03vmodvLsut3XtiiQR9OL3do7l4y6OPW+ce1wJ/G8WNKb2xhA C7uZYhwGSvnY9hPevB4wauPpaO/FRKrZH3sAnTFw= Date: Fri, 8 May 2020 18:36:09 +0100 From: Mark Brown To: Serge Semin Cc: Serge Semin , Georgy Vlasov , Ramil Zaripov , Alexey Malahov , Maxim Kaurkin , Pavel Parkhomenko , Ekaterina Skachko , Vadim Vlasov , Alexey Kolotnikov , Thomas Bogendoerfer , Paul Burton , Ralf Baechle , Arnd Bergmann , Allison Randal , Andy Shevchenko , Gareth Williams , Rob Herring , linux-mips@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/17] spi: dw: Add generic DW DMA controller support Message-ID: <20200508173609.GQ4820@sirena.org.uk> References: <20200508132943.9826-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cxMSjUqMQBJIqbX5" Content-Disposition: inline In-Reply-To: <20200508132943.9826-1-Sergey.Semin@baikalelectronics.ru> X-Cookie: Give him an evasive answer. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --cxMSjUqMQBJIqbX5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, May 08, 2020 at 04:29:25PM +0300, Serge Semin wrote: > Baikal-T1 SoC provides DW DMA controller to perform low-speed peripherals > Mem-to-Dev and Dev-to-Mem transaction. This is also applicable to the DW > APB SSI devices embedded into the SoC. Currently this type DMA device is This basically all looks good to me (without any hardware specific knowledge), I had a few comments but they were mostly procedural ones - mainly getting these bug fixes you've done merged as such. Nice work. --cxMSjUqMQBJIqbX5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl61mIkACgkQJNaLcl1U h9A+eQf/aX/eJQKNbtRlg1YQiR0kNEKfYb0h+4IxTWaR0D4O8huNg6Q6+5WvT2Yj 7mOeCIXspsfBGeaio/QMq7wEfJuA0WixGuipF+a6+fR+g46A4J33V0PlxawdRktx IaTWop1c75yO+k2WMmIcKxl2njtyhCDrPqWPan1ZyNs/EdP9Yzjb9xjuj28ZbOB5 +Too1aZWhzYiRx0UI8wfgC7msBilLvcxmHd0jmSnnBE1nsgPZE1cPme0khU+trXt XyNzPrOcMrqTJAKwkeU1ZQuYvvn07DMp+FzhjkYSfzrdC+luQwFLo6W0R0CK0aep dv7bvZv/ilTh26Ht3/pAJFJ03kdlww== =34XW -----END PGP SIGNATURE----- --cxMSjUqMQBJIqbX5--