From: Greg KH <gregkh@linuxfoundation.org>
To: John Oldman <john.oldman@polehill.co.uk>
Cc: nsaenzjulienne@suse.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2] staging: vc04_services: vchiq_connected.c: Block comment alignment
Date: Sun, 10 May 2020 08:55:19 +0200 [thread overview]
Message-ID: <20200510065519.GB3434442@kroah.com> (raw)
In-Reply-To: <20200510060645.10159-1-john.oldman@polehill.co.uk>
On Sun, May 10, 2020 at 07:06:45AM +0100, John Oldman wrote:
> Coding style issue
>
> Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
> ---
> v1: Initial attempt.
> V2: Resubmitted with shorter comment line, as suggested by Greg KH.
>
> This patch clears the checkpatch.pl "Block comments should align the * on each line" warning.
Why is this text not in the changelog area? Don't you think that it is
better than the 3 words you currently put there?
Please fix up and resend.
thanks,
greg k-h
next prev parent reply other threads:[~2020-05-10 6:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 6:06 John Oldman
2020-05-10 6:55 ` Greg KH [this message]
2020-05-10 8:35 ` John Oldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200510065519.GB3434442@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=john.oldman@polehill.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®