From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AACC5C38A2A for ; Mon, 11 May 2020 02:53:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9141420644 for ; Mon, 11 May 2020 02:53:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728219AbgEKCxj (ORCPT ); Sun, 10 May 2020 22:53:39 -0400 Received: from mga07.intel.com ([134.134.136.100]:15696 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725830AbgEKCxj (ORCPT ); Sun, 10 May 2020 22:53:39 -0400 IronPort-SDR: SaWGmu2/GPWmrimSH9z0Kb0tq2zAvfcZFi15VnZ3ARHufFpk5KTnW2PAZZYKVx698DLx5cThqp 9PYw1gxlFmYw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2020 19:53:38 -0700 IronPort-SDR: xpz1MBOyTve2Yi014woff74d4fibI1XxFdgYbe1xJfc2FdwzW8PAvDDMUi1L9EO8il9IriHxVH fK+DVivYQqdg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,378,1583222400"; d="scan'208";a="261613973" Received: from iweiny-desk2.sc.intel.com ([10.3.52.147]) by orsmga003.jf.intel.com with ESMTP; 10 May 2020 19:53:38 -0700 Date: Sun, 10 May 2020 19:53:38 -0700 From: Ira Weiny To: Arnd Bergmann Cc: VMware Graphics , Thomas Hellstrom , David Airlie , Daniel Vetter , Christian =?iso-8859-1?Q?K=F6nig?= , Christoph Hellwig , Daniel Vetter , Andy Lutomirski , Benjamin Herrenschmidt , Borislav Petkov , Chris Zankel , Dan Williams , Dave Hansen , "David S. Miller" , Helge Deller , "H. Peter Anvin" , Huang Rui , Ingo Molnar , "James E.J. Bottomley" , Max Filippov , Paul Mackerras , Peter Zijlstra , Thomas Bogendoerfer , Thomas Gleixner , Al Viro , Andrew Morton , Stephen Rothwell , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: vmwgfx: include linux/highmem.h Message-ID: <20200511025337.GA1823106@iweiny-DESK2.sc.intel.com> References: <20200508220150.649044-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200508220150.649044-1-arnd@arndb.de> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 09, 2020 at 12:01:31AM +0200, Arnd Bergmann wrote: > In order to call kmap_atomic() etc, we need to include linux/highmem.h: > > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c: In function 'vmw_bo_cpu_blit_line': > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:377:4: error: implicit declaration of function 'kunmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration] > 377 | kunmap_atomic(d->src_addr); > | ^~~~~~~~~~~~~ > | in_atomic > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:391:5: error: implicit declaration of function 'kmap_atomic_prot' [-Werror=implicit-function-declaration] > 391 | kmap_atomic_prot(d->dst_pages[dst_page], > | ^~~~~~~~~~~~~~~~ > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:390:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion] > 390 | d->dst_addr = > | ^ > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:403:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion] > 403 | d->src_addr = > | ^ > > Fixes: 46385a895322 ("drm: remove drm specific kmap_atomic code") > Signed-off-by: Arnd Bergmann I'm curious about the config which failed... Because this compiled for me. Regardless it was stupid of me to not include this. Thanks, Reviewed-by: Ira Weiny > --- > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c > index 94d456a1d1a9..1629427d5734 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c > @@ -27,6 +27,7 @@ > **************************************************************************/ > > #include "vmwgfx_drv.h" > +#include > > /* > * Template that implements find_first_diff() for a generic > -- > 2.26.0 >