From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65638C433DF for ; Wed, 13 May 2020 19:49:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D44520671 for ; Wed, 13 May 2020 19:49:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403787AbgEMTtx (ORCPT ); Wed, 13 May 2020 15:49:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2390696AbgEMTtx (ORCPT ); Wed, 13 May 2020 15:49:53 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CFD1C061A0C; Wed, 13 May 2020 12:49:51 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 09E53127F6662; Wed, 13 May 2020 12:49:50 -0700 (PDT) Date: Wed, 13 May 2020 12:49:49 -0700 (PDT) Message-Id: <20200513.124949.1617913655712734321.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, m.szyprowski@samsung.com, nsaenzjulienne@suse.de, wahrenst@gmx.net, michael.chan@broadcom.com, saeedm@mellanox.com, gospo@broadcom.com, rdunlap@infradead.org, geert+renesas@glider.be, tglx@linutronix.de, talgi@mellanox.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] net: broadcom: Select BROADCOM_PHY for BCMGENET From: David Miller In-Reply-To: <20200513155158.26110-1-f.fainelli@gmail.com> References: <20200513155158.26110-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 May 2020 12:49:50 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Wed, 13 May 2020 08:51:51 -0700 > The GENET controller on the Raspberry Pi 4 (2711) is typically > interfaced with an external Broadcom PHY via a RGMII electrical > interface. To make sure that delays are properly configured at the PHY > side, ensure that we the dedicated Broadcom PHY driver > (CONFIG_BROADCOM_PHY) is enabled for this to happen. > > Fixes: 402482a6a78e ("net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed") > Reported-by: Marek Szyprowski > Signed-off-by: Florian Fainelli Applied and queued up for -stable, thanks Florian.