From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C98E8CA90AF for ; Wed, 13 May 2020 11:56:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A71C42078C for ; Wed, 13 May 2020 11:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589370964; bh=JBhLl7MfUCS5IJ2eW+T1ci2N1MDfEAyW0mk4rekhbUU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=WKNDsmu3jloTfAzw0vQls8jeV1lZ9a9Xiwy4Bgx2VfGEGA8eF1qDbYDdxMYSlqf9J c7mxFD5QiFuPU57Ktc3Z8tQQTmm8aLC9Ln8Qj2Z4KV0R/lP+8tBLGKoQVJiL+bYY0x GerbKJslzoygeLnA8J2c4Ec39Cq+52j3WSFL4spo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731856AbgEML4D (ORCPT ); Wed, 13 May 2020 07:56:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:41150 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728286AbgEML4D (ORCPT ); Wed, 13 May 2020 07:56:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A5C18206CC; Wed, 13 May 2020 11:56:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589370963; bh=JBhLl7MfUCS5IJ2eW+T1ci2N1MDfEAyW0mk4rekhbUU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fusTrhbqb2rs17wl1cCQHfTGLDTWjurXiZ1Y7GEjb8b1DT8LoWjlilieWU+14lzTY E95XDdkRx7fKAgSAnSYViVqqpUuNaxykiLdn4cj7jCksJUZybY1Trl39qQok52aydx skfqgeMIr2i+Yx8CdOrfdIac5IOn4RKQfCJ3Ew4M= Date: Wed, 13 May 2020 13:56:00 +0200 From: Greg Kroah-Hartman To: Matej Dujava Cc: Forest Bond , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] staging: vt6655: vt6656: change order of makefile variable definitions Message-ID: <20200513115600.GB953616@kroah.com> References: <1589105615-22271-1-git-send-email-mdujava@kocurkovo.cz> <1589105615-22271-3-git-send-email-mdujava@kocurkovo.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1589105615-22271-3-git-send-email-mdujava@kocurkovo.cz> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 10, 2020 at 12:13:35PM +0200, Matej Dujava wrote: > This patch will add indentation to multiline variable and put obj-$(CONFIG_X) > at the begining of the file. Why change the order? What does that fix? Why do this? You say what you do here, but not why. And without that, I can't see the reason to accept this patch :( thanks, greg k-h