From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17E43CA90AF for ; Wed, 13 May 2020 11:58:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDA652078C for ; Wed, 13 May 2020 11:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589371109; bh=AzQ1GBsA7vb+t+sUqdhpDj5pFQccxwb/vacxaCIKKwM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=bXvm7f5yInUUIQ1djHA0spGMUEz0foOBsFs0UH6SoOI7yLDbL/0GVbEXhffKPIEM3 MilGFT9kPDi+3wt+2jQASdEXSXnutPUsMAT62TBmMJW0i2RDYe6GZI9Zdn0Ej3T73d D9WPXIsGUtEdCYpd3VEltO8cLPZTyQhoIP+9aE6o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732174AbgEML62 (ORCPT ); Wed, 13 May 2020 07:58:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:42532 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725982AbgEML60 (ORCPT ); Wed, 13 May 2020 07:58:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8996620740; Wed, 13 May 2020 11:58:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589371106; bh=AzQ1GBsA7vb+t+sUqdhpDj5pFQccxwb/vacxaCIKKwM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=veu54zijFTH9tV9hdep4oqmKRxlo+9/yg1yax/JmUfYmhty8mC9xQt4bNL0BuSlFC orkh9kp754J4DzatlKprBvYa+aUOjx7weYxvCNttblmgA0qv7E6YOp5j+PDrfKDu+p jhNi0N0h1hXgNDBNneUKt7u1RMSETOfVkcToZ7HI= Date: Wed, 13 May 2020 13:58:23 +0200 From: Greg KH To: John Oldman Cc: nsaenzjulienne@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V3] staging: vc04_services: vchiq_connected.c: Block comment alignment Message-ID: <20200513115823.GC953616@kroah.com> References: <20200510101308.10451-1-john.oldman@polehill.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200510101308.10451-1-john.oldman@polehill.co.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 10, 2020 at 11:13:08AM +0100, John Oldman wrote: > Coding style issue > This patch clears the checkpatch.pl "Block comments should align the * on each line" warning. > > Signed-off-by: John Oldman > --- > v1: Initial attempt. > v2: Resubmitted with shorter comment line, as suggested by Greg KH. > v3: Resubmitted with descriptiuon text moved into the comment area. > > .../interface/vchiq_arm/vchiq_connected.c | 32 +++++++++---------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > index 1640906e3929..993535bbc479 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c > @@ -15,10 +15,10 @@ static int g_once_init; > static struct mutex g_connected_mutex; > > /**************************************************************************** > -* > -* Function to initialize our lock. > -* > -***************************************************************************/ > + * > + * Function to initialize our lock. > + * > + ***************************************************************************/ > > static void connected_init(void) Shouldn't that really be written as: /* Function to initialize our lock */ static void connect_init(void); No need for the /****** mess, and no need for the blank line. Simple and clean is best. thanks, greg k-h