From: Mark Brown <broonie@kernel.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: "Steve Lee" <steves.lee.maxim@gmail.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
ckeepax@opensource.cirrus.com, geert@linux-m68k.org,
rf@opensource.wolfsonmicro.com,
"Shuming [范書銘]" <shumingf@realtek.com>,
"Srini Kandagatla" <srinivas.kandagatla@linaro.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
dmurphy@ti.com, jack.yu@realtek.com, nuno.sa@analog.com,
steves.lee@maximintegrated.com,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"ALSA development" <alsa-devel@alsa-project.org>,
ryan.lee.maxim@gmail.com, ryans.lee@maximintegrated.com
Subject: Re: [V3 PATCH 2/2] ASoC: max98390: Added Amplifier Driver
Date: Thu, 14 May 2020 11:16:31 +0100 [thread overview]
Message-ID: <20200514101631.GB5127@sirena.org.uk> (raw)
In-Reply-To: <CA+Px+wV7o1P41ZdidpwNFtwWL1-RYcwV3dU9R7PG+66k1L_p_A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On Thu, May 14, 2020 at 03:31:52PM +0800, Tzung-Bi Shih wrote:
> On Wed, May 13, 2020 at 3:47 PM Steve Lee <steves.lee.maxim@gmail.com> wrote:
> > +++ b/sound/soc/codecs/max98390.c
> > @@ -0,0 +1,1030 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > +/*
> > + * max98390.c -- MAX98390 ALSA Soc Audio driver
> > + *
> > + * Copyright (C) 2020 Maxim Integrated Products
> > + *
> > + */
> My previous comments on Gerrit may confuse you. Please use C++ style
> comments (i.e. // for all lines) here as the maintainer asked.
> Mark, may I ask why we need to do so? Is it also applicable to header files?
It's to make things look neater - having the two comments immediately
next to each other doesn't look intentional. Header files require a
/* */ comment for the SPDX stuff so should do that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-05-14 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 7:45 Steve Lee
2020-05-13 10:51 ` Mark Brown
2020-05-13 11:58 ` Tzung-Bi Shih
2020-05-14 10:17 ` Mark Brown
2020-05-14 12:14 ` Steve Lee
2020-05-14 7:31 ` Tzung-Bi Shih
2020-05-14 10:16 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514101631.GB5127@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=dmurphy@ti.com \
--cc=geert@linux-m68k.org \
--cc=jack.yu@realtek.com \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=perex@perex.cz \
--cc=rf@opensource.wolfsonmicro.com \
--cc=ryan.lee.maxim@gmail.com \
--cc=ryans.lee@maximintegrated.com \
--cc=shumingf@realtek.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=steves.lee.maxim@gmail.com \
--cc=steves.lee@maximintegrated.com \
--cc=tiwai@suse.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®