mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-team@fb.com, newella@fb.com
Subject: Re: [PATCH block/for-linus] iocost: don't let vrate run wild while there's no saturation signal
Date: Thu, 14 May 2020 10:51:14 -0400	[thread overview]
Message-ID: <20200514145114.GG16815@mtj.duckdns.org> (raw)
In-Reply-To: <20191015001811.GI18794@devbig004.ftw2.facebook.com>

On Mon, Oct 14, 2019 at 05:18:11PM -0700, Tejun Heo wrote:
> When the QoS targets are met and nothing is being throttled, there's
> no way to tell how saturated the underlying device is - it could be
> almost entirely idle, at the cusp of saturation or anywhere inbetween.
> Given that there's no information, it's best to keep vrate as-is in
> this state.  Before 7cd806a9a953 ("iocost: improve nr_lagging
> handling"), this was the case - if the device isn't missing QoS
> targets and nothing is being throttled, busy_level was reset to zero.
...
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Andy Newell <newella@fb.com>
> Fixes: 7cd806a9a953 ("iocost: improve nr_lagging handling")

Jens, this one fell through the cracks. It still applies with only a small
offset. Can you please apply?

Thanks.

-- 
tejun

  reply	other threads:[~2020-05-14 14:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15  0:18 Tejun Heo
2020-05-14 14:51 ` Tejun Heo [this message]
2020-05-14 15:34   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200514145114.GG16815@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=kernel-team@fb.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=newella@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome