From: Wei Li <liwei391@huawei.com>
To: Doug Anderson <dianders@chromium.org>,
Jason Wessel <jason.wessel@windriver.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: <kgdb-bugreport@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] kdb: Make the internal env 'KDBFLAGS' undefinable
Date: Sat, 16 May 2020 17:26:06 +0800 [thread overview]
Message-ID: <20200516092606.41576-1-liwei391@huawei.com> (raw)
'KDBFLAGS' is an internal variable of kdb, it is combined by 'KDBDEBUG'
and state flags. But the user can define an environment variable named
'KDBFLAGS' too, so let's make it undefinable to avoid confusion.
Signed-off-by: Wei Li <liwei391@huawei.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
v1 -> v2:
- Fix lack of braces.
kernel/debug/kdb/kdb_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
index 4fc43fb17127..75b798340300 100644
--- a/kernel/debug/kdb/kdb_main.c
+++ b/kernel/debug/kdb/kdb_main.c
@@ -423,6 +423,8 @@ int kdb_set(int argc, const char **argv)
| (debugflags << KDB_DEBUG_FLAG_SHIFT);
return 0;
+ } else if (strcmp(argv[1], "KDBFLAGS") == 0) {
+ return KDB_NOPERM;
}
/*
--
2.17.1
next reply other threads:[~2020-05-16 9:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 9:26 Wei Li [this message]
2020-05-19 11:40 ` Daniel Thompson
2020-05-19 14:11 ` liwei (GF)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200516092606.41576-1-liwei391@huawei.com \
--to=liwei391@huawei.com \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®