From: Steven Rostedt <rostedt@goodmis.org>
To: Changbin Du <changbin.du@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] function_graph: apply tracing option 'irq-info'
Date: Mon, 18 May 2020 17:25:29 -0400 [thread overview]
Message-ID: <20200518172529.35ec248e@gandalf.local.home> (raw)
In-Reply-To: <20200516160953.155630-1-changbin.du@gmail.com>
On Sun, 17 May 2020 00:09:53 +0800
Changbin Du <changbin.du@gmail.com> wrote:
> The tracing option 'irq-info' is only used by function tracer by far. This
> patch makes it also against function graph tracer. Then the two tracers
> have consistent behavior of this option.
>
> Signed-off-by: Changbin Du <changbin.du@gmail.com>
> ---
Sorry, the function graph tracer is unique, and yes, you need to enable
latency_format.
Note, irq_info is meaning less with the function_graph tracer, as it
doesn't change the latency_format with or without it.
This patch basically just makes the latency_format default for the
function_graph tracer, and changes default settings for no real advantage.
It will cause regressions.
-- Steve
prev parent reply other threads:[~2020-05-18 21:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 16:09 Changbin Du
2020-05-18 21:25 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518172529.35ec248e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=changbin.du@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®