From: David Miller <davem@davemloft.net>
To: hch@lst.de
Cc: kuba@kernel.org, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: add a new ->ndo_tunnel_ctl method to avoid a few set_fs calls v2
Date: Tue, 19 May 2020 15:45:37 -0700 (PDT) [thread overview]
Message-ID: <20200519.154537.2177911931662623148.davem@davemloft.net> (raw)
In-Reply-To: <20200519130319.1464195-1-hch@lst.de>
From: Christoph Hellwig <hch@lst.de>
Date: Tue, 19 May 2020 15:03:10 +0200
> both the ipv4 and ipv6 code have an ioctl each that can be used to create
> a tunnel using code that doesn't live in the core kernel or ipv6 module.
> Currently they call ioctls on the tunnel devices to create these, for
> which the code needs to override the address limit, which is a "feature"
> I plan to get rid of.
>
> Instead this patchset adds a new ->ndo_tunnel_ctl that can be used for
> the tunnel configuration using struct ip_tunnel_parm. The method is
> either invoked from a helper that does the uaccess and can be wired up
> as ndo_do_ioctl method, or directly from the magic IPV4/6 ioctls that
> create tunnels with kernel space arguments.
>
> Changes since v2:
> - properly propagate errors in ipip6_tunnel_prl_ctl
Looks good, series applied, thanks.
prev parent reply other threads:[~2020-05-19 22:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 13:03 Christoph Hellwig
2020-05-19 13:03 ` [PATCH 1/9] ipv4: streamline ipmr_new_tunnel Christoph Hellwig
2020-05-19 13:03 ` [PATCH 2/9] ipv4: consolidate the VIFF_TUNNEL handling in ipmr_new_tunnel Christoph Hellwig
2020-05-19 13:03 ` [PATCH 3/9] net: add a new ndo_tunnel_ioctl method Christoph Hellwig
2020-05-19 13:03 ` [PATCH 4/9] impr: use ->ndo_tunnel_ctl in ipmr_new_tunnel Christoph Hellwig
2020-05-19 13:03 ` [PATCH 5/9] sit: refactor ipip6_tunnel_ioctl Christoph Hellwig
2020-05-19 13:03 ` [PATCH 6/9] sit: impement ->ndo_tunnel_ctl Christoph Hellwig
2020-05-19 13:03 ` [PATCH 7/9] ipv6: stub out even more of addrconf_set_dstaddr if SIT is disabled Christoph Hellwig
2020-05-19 13:03 ` [PATCH 8/9] ipv6: streamline addrconf_set_dstaddr Christoph Hellwig
2020-05-19 13:03 ` [PATCH 9/9] ipv6: use ->ndo_tunnel_ctl in addrconf_set_dstaddr Christoph Hellwig
2020-05-19 22:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519.154537.2177911931662623148.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®