From: Nathan Chancellor <natechancellor@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: kbuild test robot <lkp@intel.com>, Christoph Hellwig <hch@lst.de>,
kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
linux-kernel@vger.kernel.org, x86@kernel.org,
Benjamin Thiel <b.thiel@posteo.de>
Subject: Re: [tip:x86/mm 1/23] arch/x86/mm/init.c:75:6: warning: no previous prototype for function 'x86_has_pat_wp'
Date: Tue, 19 May 2020 14:25:41 -0700 [thread overview]
Message-ID: <20200519212541.GA3580016@ubuntu-s3-xlarge-x86> (raw)
In-Reply-To: <20200519205505.GD444@zn.tnic>
On Tue, May 19, 2020 at 10:55:05PM +0200, Borislav Petkov wrote:
> On Wed, May 20, 2020 at 01:51:25AM +0800, kbuild test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/mm
> > head: bd1de2a7aace4d1d312fb1be264b8fafdb706208
> > commit: 1f6f655e01adebf5bd5e6c3da2e843c104ded051 [1/23] x86/mm: Add a x86_has_pat_wp() helper
> > config: x86_64-randconfig-r012-20200519 (attached as .config)
> > compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 135b877874fae96b4372c8a3fbfaa8ff44ff86e3)
> > reproduce:
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # install x86_64 cross compiling tool for clang build
> > # apt-get install binutils-x86-64-linux-gnu
> > git checkout 1f6f655e01adebf5bd5e6c3da2e843c104ded051
> > # save the attached .config to linux build tree
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kbuild test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>, old ones prefixed by <<):
> >
> > >> arch/x86/mm/init.c:75:6: warning: no previous prototype for function 'x86_has_pat_wp' [-Wmissing-prototypes]
> > bool x86_has_pat_wp(void)
> > ^
>
> Triggers with gcc too:
>
> make W=1 arch/x86/mm/init.o
>
> ...
>
> arch/x86/mm/init.c:81:6: warning: no previous prototype for ‘x86_has_pat_wp’ [-Wmissing-prototypes]
> 81 | bool x86_has_pat_wp(void)
> | ^~~~~~~~~~~~~~
>
>
> -Wmissing-prototypes is default off, though, dunno why clang 11 has it
> on.
It doesn't: https://godbolt.org/z/rU5_5H
I assume this is caused by some sort of internal change to the 0day
infrastructure (testing W=1?)
I cannot see this without adding W=1 to make at the listed commit with
the provided config.
Cheers,
Nathan
> Anyway, something for Benni to fix. CCed and leaving the rest for him as
> reference.
>
> > arch/x86/mm/init.c:75:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> > bool x86_has_pat_wp(void)
> > ^
> > static
> > arch/x86/mm/init.c:866:13: warning: no previous prototype for function 'mem_encrypt_free_decrypted_mem' [-Wmissing-prototypes]
> > void __weak mem_encrypt_free_decrypted_mem(void) { }
> > ^
> > arch/x86/mm/init.c:866:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> > void __weak mem_encrypt_free_decrypted_mem(void) { }
> > ^
> > static
> > 2 warnings generated.
> >
> > vim +/x86_has_pat_wp +75 arch/x86/mm/init.c
> >
> > 73
> > 74 /* Check that the write-protect PAT entry is set for write-protect */
> > > 75 bool x86_has_pat_wp(void)
> > 76 {
> > 77 return __pte2cachemode_tbl[_PAGE_CACHE_MODE_WP] == _PAGE_CACHE_MODE_WP;
> > 78 }
> > 79
> >
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
>
>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
>
next prev parent reply other threads:[~2020-05-19 21:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 17:51 kbuild test robot
2020-05-19 20:55 ` Borislav Petkov
2020-05-19 21:25 ` Nathan Chancellor [this message]
2020-05-19 22:12 ` Nick Desaulniers
2020-05-19 23:49 ` Li, Philip
2020-05-20 0:26 ` Nick Desaulniers
2020-05-20 0:52 ` Philip Li
2020-05-20 1:07 ` Nick Desaulniers
2020-05-20 1:24 ` Philip Li
2020-05-20 17:19 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519212541.GA3580016@ubuntu-s3-xlarge-x86 \
--to=natechancellor@gmail.com \
--cc=b.thiel@posteo.de \
--cc=bp@alien8.de \
--cc=clang-built-linux@googlegroups.com \
--cc=hch@lst.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®