From: Jason Gunthorpe <jgg@ziepe.ca>
To: Divya Indi <divya.indi@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
"Kaike Wan" <kaike.wan@intel.com>,
"Gerd Rausch" <gerd.rausch@oracle.com>,
"Håkon Bugge" <haakon.bugge@oracle.com>,
"Srinivas Eeda" <srinivas.eeda@oracle.com>,
"Rama Nichanamatlu" <rama.nichanamatlu@oracle.com>,
"Doug Ledford" <dledford@redhat.com>
Subject: Re: [PATCH 1/2] IB/sa: Resolving use-after-free in ib_nl_send_msg.
Date: Tue, 19 May 2020 21:10:45 -0300 [thread overview]
Message-ID: <20200520001045.GA31189@ziepe.ca> (raw)
In-Reply-To: <272dbe83-a72b-d38b-6993-d3bbda50a7d1@oracle.com>
On Tue, May 19, 2020 at 04:30:52PM -0700, Divya Indi wrote:
> Hi Jason,
>
> I wanted to follow up to see if you got a chance to review the following reply?
Not yet, it still seems bad to be doing code like this.
If two threads are sharing memory they really need to use a
refcount/kref not rely on some sketchy thing with flags. It is very
hard to tell if the sketchy thing with flags is correct or not.
Jason
next prev parent reply other threads:[~2020-05-20 0:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 18:34 Divya Indi
2020-05-07 18:34 ` [PATCH 1/2] IB/sa: " Divya Indi
2020-05-07 19:06 ` Wan, Kaike
2020-05-07 19:36 ` Mark Bloch
2020-05-07 20:16 ` Wan, Kaike
2020-05-07 21:40 ` Mark Bloch
2020-05-11 21:10 ` Divya Indi
2020-05-11 21:06 ` Divya Indi
2020-05-12 11:15 ` Wan, Kaike
2020-05-08 0:08 ` Jason Gunthorpe
2020-05-11 21:26 ` Divya Indi
2020-05-13 15:00 ` Jason Gunthorpe
2020-05-13 21:02 ` Divya Indi
2020-05-19 23:30 ` Divya Indi
2020-05-20 0:10 ` Jason Gunthorpe [this message]
[not found] ` <20200508110302.17872-1-hdanton@sina.com>
2020-05-11 21:30 ` Divya Indi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520001045.GA31189@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=divya.indi@oracle.com \
--cc=dledford@redhat.com \
--cc=gerd.rausch@oracle.com \
--cc=haakon.bugge@oracle.com \
--cc=kaike.wan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rama.nichanamatlu@oracle.com \
--cc=srinivas.eeda@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome