From: andi@notmuch.email
To: Brendan Shanks <bshanks@codeweavers.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Babu Moger <Babu.Moger@amd.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Jason Yan <yanaijie@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: umip: AMD Ryzen 3900X, pagefault after emulate SLDT/SIDT instruction
Date: Wed, 20 May 2020 03:08:53 +0200 [thread overview]
Message-ID: <20200520010853.635wep2ewq4zpn2y@wrt> (raw)
In-Reply-To: <2330FAB4-A6CE-49E7-921C-B7D55763BDED@codeweavers.com>
On 11:56 19.05.20, Brendan Shanks wrote:
> The problem is that the kernel does not emulate/spoof the SLDT instruction, only SGDT, SIDT, and SMSW.
> SLDT and STR weren't thought to be commonly used, so emulation/spoofing wasn’t added.
> In the last few months I have seen reports of one or two (32-bit) Windows games that use SLDT though.
> Can you share more information about the application you’re running?
I'll try to create a very simple reproducer for this case in the next
days. Unfortunately I don't have the source of the original application.
I can mail you instructions about it directly, if required.
> Maybe the best path is to add kernel emulation/spoofing for SLDT and
> STR on 32 and 64-bit, just to cover all the cases. It should be a
> pretty simple patch, I’ll start working on it.
Check the other mail from Ricardo, you can probably safe that effort :-)
> Alternately, I did work on a Wine patch to emulate the UMIP
> instructions in user-space, but it adds a lot of code and I don’t
> think there’s much appetite for it in upstream Wine (especially since
> the kernel emulation is sufficient for almost all cases).
> https://www.winehq.org/pipermail/wine-devel/2020-February/160027.html
Yeah that seems like the less favorable effort. My best guess is that
this might not be limited to Wine thus handling in the kernel might be
best.
> In the meantime, an easy way to disable UMIP without rebuilding the
> kernel is to pass 'clearcpuid=514’ on the kernel command line.
Nice, I'll use that next time :-)
next prev parent reply other threads:[~2020-05-20 1:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 14:38 Andreas Rammhold
2020-05-19 18:56 ` Brendan Shanks
2020-05-19 19:43 ` Ricardo Neri
2020-05-20 0:54 ` Andy Lutomirski
2020-05-21 0:56 ` Ricardo Neri
2020-05-21 1:16 ` Andy Lutomirski
2020-05-20 1:04 ` andi
2020-05-23 2:17 ` Andreas Rammhold
2020-05-26 13:33 ` Ricardo Neri
2020-05-28 11:36 ` Andreas Rammhold
2020-05-20 1:08 ` andi [this message]
2020-05-23 2:21 ` andi
2020-05-20 0:17 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520010853.635wep2ewq4zpn2y@wrt \
--to=andi@notmuch.email \
--cc=Babu.Moger@amd.com \
--cc=bp@alien8.de \
--cc=bshanks@codeweavers.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=wangkefeng.wang@huawei.com \
--cc=x86@kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®