mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
Cc: rui.zhang@intel.com, rjw@rjwysocki.net, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	srinivas.pandruvada@linux.intel.com
Subject: Re: [PATCH] powercap: remove unused local MSR define
Date: Wed, 20 May 2020 14:53:58 +0300	[thread overview]
Message-ID: <20200520115358.GR1634618@smile.fi.intel.com> (raw)
In-Reply-To: <1589974578-26791-1-git-send-email-sumeet.r.pawnikar@intel.com>

On Wed, May 20, 2020 at 05:06:18PM +0530, Sumeet Pawnikar wrote:
> From: "Pawnikar, Sumeet" <sumeet.r.pawnikar@intel.com>
> 
> Remove unused PLATFORM_POWER_LIMIT MSR local definition from file
> intel_rapl_common.c. This was missed while splitting old RAPL code
> intel_rapl.c file into two new files intel_rapl_msr.c and
> intel_rapl_common.c as per the commit 3382388d7148
> ("intel_rapl: abstract RAPL common code"). Currently, this #define
> entry is being used only in intel_rapl_msr.c file and local definition
> present in this file.

> Signed-off-by: Pawnikar, Sumeet <sumeet.r.pawnikar@intel.com>

Reorganize this to avoid comma (this also should make From: gone in the top of
this message). After addressing,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

> ---
>  drivers/powercap/intel_rapl_common.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c
> index eb328655bc01..5527a7c76309 100644
> --- a/drivers/powercap/intel_rapl_common.c
> +++ b/drivers/powercap/intel_rapl_common.c
> @@ -26,9 +26,6 @@
>  #include <asm/cpu_device_id.h>
>  #include <asm/intel-family.h>
>  
> -/* Local defines */
> -#define MSR_PLATFORM_POWER_LIMIT	0x0000065C
> -
>  /* bitmasks for RAPL MSRs, used by primitive access functions */
>  #define ENERGY_STATUS_MASK      0xffffffff
>  
> -- 
> 1.7.9.5
> 

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2020-05-20 11:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20 11:36 Sumeet Pawnikar
2020-05-20 11:53 ` Andy Shevchenko [this message]
2020-05-21  6:44 Sumeet Pawnikar
2020-05-25  9:01 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200520115358.GR1634618@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=rui.zhang@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=sumeet.r.pawnikar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome