From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD8C7C433E0 for ; Wed, 20 May 2020 18:52:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4451206C3 for ; Wed, 20 May 2020 18:52:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X284vZgq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727022AbgETSwd (ORCPT ); Wed, 20 May 2020 14:52:33 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:37468 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726893AbgETSwc (ORCPT ); Wed, 20 May 2020 14:52:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590000750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xN2W+VHPdONngIsn/cmQXo9hulCtlz3Fu6VwpKF5hZ0=; b=X284vZgqmJgpSpBSWcgA8De6eA3AOP89uYBzyWHIdO3rl7fGKkVhjwpshemFdEODrsEAZE S98hc+i5FCtwOYqk/v/wC1vgpncX0ZF76XZWCGeE7ja2Zuh1ZY//7b8qjWBMzfwR4Ls9kO 5irRIoWZnTzCKjyu2JooYqpk3a6mHyk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-M3_QCOQaNSeEfd1ijpXfBg-1; Wed, 20 May 2020 14:52:28 -0400 X-MC-Unique: M3_QCOQaNSeEfd1ijpXfBg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 85C19464; Wed, 20 May 2020 18:52:27 +0000 (UTC) Received: from starship.redhat.com (unknown [10.35.207.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 66D014739A; Wed, 20 May 2020 18:52:25 +0000 (UTC) From: Maxim Levitsky To: linux-kernel@vger.kernel.org Cc: Andreas Noever , Michael Jamet , Mika Westerberg , Jiri Kosina , linux-usb@vger.kernel.org (open list:THUNDERBOLT DRIVER), Yehezkel Bernat , Maxim Levitsky Subject: [PATCH 1/1] thunderbolt: add trivial .shutdown Date: Wed, 20 May 2020 21:52:21 +0300 Message-Id: <20200520185221.122283-2-mlevitsk@redhat.com> In-Reply-To: <20200520185221.122283-1-mlevitsk@redhat.com> References: <20200520185221.122283-1-mlevitsk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On my machine, a kexec with this driver loaded in the old kernel causes a very long delay on boot in the kexec'ed kernel, most likely due to unclean shutdown prior to that. Unloading thunderbolt driver prior to kexec allows kexec to work as fast as regular kernel boot, as well as adding this .shutdown pointer. Shutting a device prior to the shutdown completely is always a good idea IMHO to help with kexec, and this one-liner patch implements it. Signed-off-by: Maxim Levitsky --- drivers/thunderbolt/nhi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c index 1be491ecbb45..4046642e6aec 100644 --- a/drivers/thunderbolt/nhi.c +++ b/drivers/thunderbolt/nhi.c @@ -1285,6 +1285,7 @@ static struct pci_driver nhi_driver = { .id_table = nhi_ids, .probe = nhi_probe, .remove = nhi_remove, + .shutdown = nhi_remove, .driver.pm = &nhi_pm_ops, }; -- 2.25.4