From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D29C5C433E0 for ; Sat, 23 May 2020 20:17:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B727920735 for ; Sat, 23 May 2020 20:17:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387965AbgEWURn (ORCPT ); Sat, 23 May 2020 16:17:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387834AbgEWURn (ORCPT ); Sat, 23 May 2020 16:17:43 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F58BC061A0E for ; Sat, 23 May 2020 13:17:43 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jcaaL-0000Jz-7t; Sat, 23 May 2020 22:17:33 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1jcaaI-0002gY-TY; Sat, 23 May 2020 22:17:30 +0200 Date: Sat, 23 May 2020 22:17:30 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Sven Van Asbroeck Cc: Andy Shevchenko , Mika Westerberg , YueHaibing , Thierry Reding , linux-pwm@vger.kernel.org, kernel-janitors@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH -next] pwm: pca9685: Remove set but not used variable 'pwm' Message-ID: <20200523201730.o7y7pent4hjtgia3@pengutronix.de> References: <20190606151111.14237-1-TheSven73@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190606151111.14237-1-TheSven73@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 06, 2019 at 11:11:11AM -0400, Sven Van Asbroeck wrote: > I was able to test the patch [1] exclusion mechanism without access to actual > hardware - by giving it a dummy regmap. See patch below. > > Test cases (all via sysfs): > 1. verify requested pwm cannot be requested as gpio > 2. verify requested gpio cannot be requested as pwm > 3. verify pwm "all LEDs" cannot be used if pwms/gpios in use > 4. verify pwms/gpios cannot be requested if pwm "all LEDs" in use > > All test cases ok. > Obviously, I could not test multi-threaded correctness. > > [1] https://lkml.org/lkml/2019/6/4/1039 Is this patch still relevant? A patch similar to YueHaibing's one was merged in the meantime but I guess the underlying problem is still relevant. Sven, do you care enough to recheck and create a patch on top of a more recent tree? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |