From: <qiang.zhang@windriver.com>
To: <tj@kernel.org>
Cc: <jiangshanlai@gmail.com>, <markus.elfring@web.de>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] workqueue: Fix double kfree for rescuer
Date: Mon, 25 May 2020 15:59:01 +0800 [thread overview]
Message-ID: <20200525075901.12699-1-qiang.zhang@windriver.com> (raw)
From: Zhang Qiang <qiang.zhang@windriver.com>
The duplicate memory release should be deleted from the implementation
of the callback function "rcu_free_wq".
Fixes: 6ba94429c8e7 ("workqueue: Reorder sysfs code")
Signed-off-by: Zhang Qiang <qiang.zhang@windriver.com>
---
kernel/workqueue.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 891ccad5f271..a2451cdcd503 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -3491,7 +3491,6 @@ static void rcu_free_wq(struct rcu_head *rcu)
else
free_workqueue_attrs(wq->unbound_attrs);
- kfree(wq->rescuer);
kfree(wq);
}
--
2.24.1
next reply other threads:[~2020-05-25 7:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 7:59 qiang.zhang [this message]
2020-05-25 8:20 ` [PATCH v2] workqueue: Delete duplicate kfree() call for “rescuer” from rcu_free_wq() Markus Elfring
2020-05-25 9:50 ` [PATCH v2] workqueue: Fix double kfree for rescuer Markus Elfring
2020-05-25 9:55 ` Markus Elfring
2020-05-25 10:19 ` qzhang2
2020-05-25 10:40 ` [v2] " Markus Elfring
2020-05-26 2:05 ` qzhang2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525075901.12699-1-qiang.zhang@windriver.com \
--to=qiang.zhang@windriver.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.elfring@web.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®