From: Xie He <hexie3605@gmail.com>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>,
Xie He <hexie3605@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drivers/net/wan/lapbether.c: Fixed kernel panic when used with AF_PACKET sockets
Date: Wed, 27 May 2020 20:21:33 -0700 [thread overview]
Message-ID: <20200528032134.13752-1-hexie3605@gmail.com> (raw)
When we use "AF_PACKET" sockets to send data directly over LAPB over
Ethernet using this driver, the kernel will panic because of
insufficient header space allocated in the "sk_buff" struct.
The header space needs 18 bytes because:
the lapbether driver will remove a pseudo header of 1 byte;
the lapb module will prepend the LAPB header of 2 or 3 bytes;
the lapbether driver will prepend a length field of 2 bytes and the
Ethernet header of 14 bytes.
So -1 + 3 + 16 = 18.
Signed-off-by: Xie He <hexie3605@gmail.com>
---
drivers/net/wan/lapbether.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index e30d91a38cfb..619413f5d432 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -303,7 +303,8 @@ static void lapbeth_setup(struct net_device *dev)
dev->netdev_ops = &lapbeth_netdev_ops;
dev->needs_free_netdev = true;
dev->type = ARPHRD_X25;
- dev->hard_header_len = 3;
+ /* 18 = -1 (lapbether) + 3 (lapb) + 16 (lapbether) */
+ dev->hard_header_len = 18;
dev->mtu = 1000;
dev->addr_len = 0;
}
--
2.25.1
next reply other threads:[~2020-05-28 3:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 3:21 Xie He [this message]
2020-06-01 18:32 ` David Miller
2020-06-30 16:01 ` Xie He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528032134.13752-1-hexie3605@gmail.com \
--to=hexie3605@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madhuparnabhowmik04@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®