From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67DB1C433E1 for ; Thu, 28 May 2020 07:46:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 478E6208E4 for ; Thu, 28 May 2020 07:46:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbgE1HqW (ORCPT ); Thu, 28 May 2020 03:46:22 -0400 Received: from elvis.franken.de ([193.175.24.41]:42145 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbgE1HqW (ORCPT ); Thu, 28 May 2020 03:46:22 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jeDF0-0000aG-02; Thu, 28 May 2020 09:46:14 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 173BFC05A4; Thu, 28 May 2020 09:45:39 +0200 (CEST) Date: Thu, 28 May 2020 09:45:39 +0200 From: Thomas Bogendoerfer To: Jiaxun Yang Cc: linux-mips@vger.kernel.org, Huacai Chen , linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: Loongson64: Define PCI_IOBASE Message-ID: <20200528074539.GC10708@alpha.franken.de> References: <20200527131721.646926-1-jiaxun.yang@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200527131721.646926-1-jiaxun.yang@flygoat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 09:17:21PM +0800, Jiaxun Yang wrote: > PCI_IOBASE is used to create VM maps for PCI I/O ports, it is > required by generic PCI drivers to make memory mapped I/O range > work. > > To deal with legacy drivers that have fixed I/O ports range we > reserved 0x10000 in PCI_IOBASE, should be enough for i8259 i8042 > stuff. > > Signed-off-by: Jiaxun Yang > --- > .../mips/include/asm/mach-loongson64/spaces.h | 8 ++++ > arch/mips/loongson64/init.c | 42 ++++++++++++++++++- > 2 files changed, 48 insertions(+), 2 deletions(-) that looks so much nicer, thank you for doing this. Applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]