From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: dsahern@kernel.org, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, kuba@kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][net-next] nexthop: fix incorrect allocation failure on nhg->spare
Date: Fri, 29 May 2020 17:15:21 -0700 (PDT) [thread overview]
Message-ID: <20200529.171521.699478164991447623.davem@davemloft.net> (raw)
In-Reply-To: <20200528145114.420100-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Thu, 28 May 2020 15:51:14 +0100
> @@ -1185,7 +1185,7 @@ static struct nexthop *nexthop_create_group(struct net *net,
>
> /* spare group used for removals */
> nhg->spare = nexthop_grp_alloc(num_nh);
I don't even see this line in the current net-next tree nor any references
to ->spare.
What am I missing?
prev parent reply other threads:[~2020-05-30 0:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 14:51 Colin King
2020-05-28 14:53 ` Nikolay Aleksandrov
2020-05-28 14:55 ` David Ahern
2020-05-28 14:55 ` Nikolay Aleksandrov
2020-05-28 15:53 ` Colin Ian King
2020-05-28 15:55 ` Nikolay Aleksandrov
2020-05-28 15:56 ` Colin Ian King
2020-05-30 0:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529.171521.699478164991447623.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=dsahern@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®