From: David Sterba <dsterba@suse.cz>
To: Joe Perches <joe@perches.com>
Cc: Yi Wang <wang.yi59@zte.com.cn>,
clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
xue.zhihong@zte.com.cn, wang.liang82@zte.com.cn,
Liao Pingfang <liao.pingfang@zte.com.cn>
Subject: Re: [PATCH] btrfs: Replace kmalloc with kzalloc in the error message
Date: Fri, 29 May 2020 15:05:46 +0200 [thread overview]
Message-ID: <20200529130546.GR18421@twin.jikos.cz> (raw)
In-Reply-To: <5418df56f217437bd33c4cb70098db29c177d5b3.camel@perches.com>
On Thu, May 28, 2020 at 07:03:45PM -0700, Joe Perches wrote:
> On Fri, 2020-05-29 at 09:00 +0800, Yi Wang wrote:
> > From: Liao Pingfang <liao.pingfang@zte.com.cn>
> >
> > Use kzalloc instead of kmalloc in the error message according to
> > the previous kzalloc() call.
> []
> > diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c
> []
> > @@ -632,7 +632,7 @@ static int btrfsic_process_superblock(struct btrfsic_state *state,
> >
> > selected_super = kzalloc(sizeof(*selected_super), GFP_NOFS);
> > if (NULL == selected_super) {
> > - pr_info("btrfsic: error, kmalloc failed!\n");
> > + pr_info("btrfsic: error, kzalloc failed!\n");
>
> As there is a dump_stack() done on memory allocation
> failures, these messages might as well be deleted instead.
I wouldn't bother changing the strings, removing them entirely sounds
like a better idea to me.
prev parent reply other threads:[~2020-05-29 13:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 1:00 Yi Wang
2020-05-29 2:03 ` Joe Perches
2020-05-29 13:05 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529130546.GR18421@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=joe@perches.com \
--cc=josef@toxicpanda.com \
--cc=liao.pingfang@zte.com.cn \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®