mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@linux.alibaba.com>
Cc: linux-kernel@vger.kernel.org, Lai Jiangshan <jiangshanlai@gmail.com>
Subject: Re: [PATCH 3/4] workqueue: free wq->unbound_attrs earlier
Date: Fri, 29 May 2020 10:23:47 -0400	[thread overview]
Message-ID: <20200529142347.GD3530656@mtj.duckdns.org> (raw)
In-Reply-To: <20200529065903.1758-4-laijs@linux.alibaba.com>

On Fri, May 29, 2020 at 06:59:01AM +0000, Lai Jiangshan wrote:
> wq->unbound_attrs is never accessed in rcu read site, so that
> it can be freed earlier and relieves memory pressure earlier,
> although slightly.
> 
> Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>

I don't think this is gonna make a material difference in terms of memory
pressure and would much prefer keep freeing together so that we don't
complicate the lifetime rules.

Thanks.

-- 
tejun

  reply	other threads:[~2020-05-29 14:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-29  6:58 [PATCH 0/4] workqueue: simple cleanups Lai Jiangshan
2020-05-29  6:58 ` [PATCH 1/4] workqueue: void unneeded requeuing the pwq in rescuer thread Lai Jiangshan
2020-05-29 14:22   ` Tejun Heo
2020-05-29  6:59 ` [PATCH 2/4] workqueue: don't check wq->rescuer in rescuer Lai Jiangshan
2020-05-29 14:14   ` Tejun Heo
2020-05-29 14:58     ` Lai Jiangshan
2020-05-29 15:04       ` Tejun Heo
2020-05-29  6:59 ` [PATCH 3/4] workqueue: free wq->unbound_attrs earlier Lai Jiangshan
2020-05-29 14:23   ` Tejun Heo [this message]
2020-05-29  6:59 ` [PATCH 4/4] workqueue: remove useless unlock() and lock() in series Lai Jiangshan
2020-05-29 14:26   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200529142347.GD3530656@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=laijs@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome