From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63E83C433E0 for ; Mon, 1 Jun 2020 20:41:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 317BA206E2 for ; Mon, 1 Jun 2020 20:41:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591044103; bh=U9+OLYmnQJ/S6CKXNOpWoO1aaLc3uAuA6rSchb2QAJA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=b/arg1+uVNuQbFPe1c1cmQuE1abuskN6enc5rjz9Wb8S6x7/u7JY7cV9cebHi7axB M6mG6ddthh9GcjCgC2Dh8JhS+ya7qElsalps9cgXM4YJQ3KWAQil9GlqP3JXjm2blQ AP9QClc4jgX8NLatypBzTuMisCiTwO0J3Ts4W8bg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728461AbgFAUlm (ORCPT ); Mon, 1 Jun 2020 16:41:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727096AbgFAUlm (ORCPT ); Mon, 1 Jun 2020 16:41:42 -0400 Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB557C061A0E; Mon, 1 Jun 2020 13:41:40 -0700 (PDT) Received: by mail-qt1-x844.google.com with SMTP id y1so8841429qtv.12; Mon, 01 Jun 2020 13:41:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=L+uLUR36iZwv1+/Dy3Hfm2UrEbVl2bjczRKyy90BPpE=; b=PWCHMPP/FMEx/I6GfNxXPPjzAYeuBQTx5FtXEpVtAugYbaMmDu89qqiS35elSTan33 lit9wYr60A6K+ISfwBfB5Y2SKX23e1iD8DnwH7ORwmRE/5fhavh2x57MLYGpxZzZscRH Dnl9vnY4akko5HRMggp3kFPv9qN8xf3dpAfbmxQEQbzsSmnCiu4+966ndpGoY3PSbLZt ihXY0wjzgzPuj63KUraYWKx7EXymXdJSPVZ4UqNsvdDNVvTd2lzTEXoH/ZlGiZ5dRKnL TxaooD4sfamdU+TvyW9E/dFQ/zOdmI00zhe+d4mXfDeTPgm1TbqWSjPK9htLsKRCQPOn SXYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=L+uLUR36iZwv1+/Dy3Hfm2UrEbVl2bjczRKyy90BPpE=; b=XiC+WB+MlIpZuYYESG2Br+q38Apbp9DNsd1/3RQBkpmWXlthbxTO+HzjQ4xFLPlHyh epP1oidenEOeuiyp5l/508OqnQLZa18ph6dnAhHKFkEfyLF6RCmrlt42REDMuBF67dHf M6AZ5koJ0gwE1xfPEooBSjfFKXh2YCLYkbZ+D919MSmzVPgMPAQzT5XTRTDzzyI2VJzK 2PJr+Ww+WLJYrEK+LZt/MsizHMX2qZXtU+9MP1kX3Z/57UgIhdCO8NpqDH5yMoEdfBRl BCB8YsnqRrstE8HwZYTnLKs414Qeh1IM+dSUZImR+tUhgvZQA0l8jqa62VzoLKo5EeW1 TkHA== X-Gm-Message-State: AOAM531KO2XkvMia70UXa3xS76G/XxsnF5pViouoMrENxu9H7E65kDu2 UZvUhUqx6SQbowljNS2RB+s= X-Google-Smtp-Source: ABdhPJzQbUEqkFEmiFfh8KcdmGtpQNqlLRj6qcQXNgbYHXS3zOVnwGfWgZspy18hDqATF2iV5kS4mw== X-Received: by 2002:ac8:2492:: with SMTP id s18mr23497170qts.81.1591044099697; Mon, 01 Jun 2020 13:41:39 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:eb8b]) by smtp.gmail.com with ESMTPSA id w10sm475193qtc.15.2020.06.01.13.41.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 13:41:39 -0700 (PDT) Date: Mon, 1 Jun 2020 16:41:37 -0400 From: Tejun Heo To: Boris Burkov Cc: Jens Axboe , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 1/2 blk-cgroup/for-5.8] blk-cgroup: make iostat functions visible to stat printing Message-ID: <20200601204137.GE31548@mtj.thefacebook.com> References: <20200601154351.GD31548@mtj.thefacebook.com> <20200601201143.1657414-1-boris@bur.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200601201143.1657414-1-boris@bur.io> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 01, 2020 at 01:11:43PM -0700, Boris Burkov wrote: > Previously, the code which printed io.stat only needed access to the > generic rstat flushing code, but since we plan to write some more > specific code for preparing root cgroup stats, we need to manipulate > iostat structs directly. Since declaring static functions ahead does not > seem like common practice in this file, simply move the iostat functions > up. We only plan to use blkg_iostat_set, but it seems better to keep them > all together. > > Signed-off-by: Boris Burkov Acked-by: Tejun Heo Thanks. -- tejun