From: Mark Brown <broonie@kernel.org>
To: Navid Emamdoost <navid.emamdoost@gmail.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
emamd001@umn.edu, wu000273@umn.edu, kjlu@umn.edu,
smccaman@umn.edu
Subject: Re: [PATCH] spi: spi-ti-qspi: call pm_runtime_put on pm_runtime_get failure
Date: Tue, 2 Jun 2020 10:54:11 +0100 [thread overview]
Message-ID: <20200602095411.GB5684@sirena.org.uk> (raw)
In-Reply-To: <20200602043637.5317-1-navid.emamdoost@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
On Mon, Jun 01, 2020 at 11:36:37PM -0500, Navid Emamdoost wrote:
> The counter is incremented via pm_runtime_get even in failure case.
> To correct the counter call pm_runtime_put in case of failure, too.
Someone already sent a fix for this but in any case this isn't the
correct fix - pm_runtime_put() will also undo the pm_runtime_resume()
that pm_runtime_get() failed to do which is wrong. pm_runtime_idle() is
what you're looking for.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-02 9:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 4:36 Navid Emamdoost
2020-06-02 9:54 ` Mark Brown [this message]
2020-06-02 8:40 Markus Elfring
2020-06-02 9:49 ` Mark Brown
2020-06-02 10:02 ` Markus Elfring
2020-06-02 14:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602095411.GB5684@sirena.org.uk \
--to=broonie@kernel.org \
--cc=emamd001@umn.edu \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=smccaman@umn.edu \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®