From: Fenghua Yu <fenghua.yu@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] x86/resctrl: fix a NULL vs IS_ERR() static checker warning
Date: Tue, 2 Jun 2020 15:17:28 -0700 [thread overview]
Message-ID: <20200602221727.GA59412@romley-ivt3.sc.intel.com> (raw)
In-Reply-To: <20200602193611.GA190851@mwanda>
On Tue, Jun 02, 2020 at 10:36:11PM +0300, Dan Carpenter wrote:
> The callers don't expect *d_cdp to be set to an error pointer, they only
> check for NULL. This leads to a static checker warning:
>
> arch/x86/kernel/cpu/resctrl/rdtgroup.c:2648 __init_one_rdt_domain()
> warn: 'd_cdp' could be an error pointer
>
> This would not trigger a bug in this specific case because
> __init_one_rdt_domain() calls it with a valid domain that would not have
> a negative id and thus not trigger the return of the ERR_PTR(). If this
> was a negative domain id then the call to rdt_find_domain() in
> domain_add_cpu() would have returned the ERR_PTR() much earlier and the
> creation of the domain with an invalid id would have been prevented.
>
> Even though a bug is not triggered currently the right and safe thing to
> do is to set the pointer to NULL because that is what can be checked for
> when the caller is handling the CDP and non-CDP cases.
>
> Fixes: 52eb74339a62 ("x86/resctrl: Fix rdt_find_domain() return value and checks")
Acked-by: Fenghua Yu <fenghua.yu@intel.com>
next prev parent reply other threads:[~2020-06-02 22:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 19:36 Dan Carpenter
2020-06-02 22:17 ` Fenghua Yu [this message]
2020-06-17 10:25 ` [tip: x86/urgent] x86/resctrl: Fix a NULL vs IS_ERR() static checker warning in rdt_cdp_peer_get() tip-bot2 for Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602221727.GA59412@romley-ivt3.sc.intel.com \
--to=fenghua.yu@intel.com \
--cc=bp@alien8.de \
--cc=dan.carpenter@oracle.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®