From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64FEDC433DF for ; Thu, 4 Jun 2020 07:15:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DA86207F9 for ; Thu, 4 Jun 2020 07:15:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="iMqSQbhO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727839AbgFDHPB (ORCPT ); Thu, 4 Jun 2020 03:15:01 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:51547 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725959AbgFDHPB (ORCPT ); Thu, 4 Jun 2020 03:15:01 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 49cxql476kz9sSn; Thu, 4 Jun 2020 17:14:59 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1591254899; bh=3uGi9bhteSUKHX4dK9fb2u7dJ+8y8PDGwBDZ768ai2o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iMqSQbhOLghOv8X+Om/fx5cEcudjWzNmthFNcIWGmNAa4SlMWdJQhmzBLoZitwxys Cgx6ii6pcWf/O7HgXFlc+Q05riMwz5ihgpsBCUzhZJWLiJ04MC3Lcf7wmh5NnLVJuD 83r0rV6pN3vVi046+JSxemJ45pvi8WWX51MbHU98= Date: Thu, 4 Jun 2020 17:14:48 +1000 From: David Gibson To: Andy Shevchenko Cc: Serge Semin , Joel Stanley , Serge Semin , Wolfram Sang , Andy Shevchenko , Rob Herring , devicetree-compiler@vger.kernel.org, Linux Kernel Mailing List , Stephen Rothwell , Arnd Bergmann Subject: Re: [PATCH v3 2/2] checks: Improve i2c reg property checking Message-ID: <20200604071448.GJ228651@umbus.fritz.box> References: <20200528085650.1417942-1-joel@jms.id.au> <20200528085650.1417942-3-joel@jms.id.au> <20200602080104.4vqobktck357j52v@mobilestation> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zYo4Elh1vtcYNvbq" Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zYo4Elh1vtcYNvbq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 02, 2020 at 11:28:05AM +0300, Andy Shevchenko wrote: > On Tue, Jun 2, 2020 at 11:03 AM Serge Semin > wrote: > > On Thu, May 28, 2020 at 06:26:50PM +0930, Joel Stanley wrote: >=20 > ... >=20 > > > +#define I2C_TEN_BIT_ADDRESS (1 << 31) > > > > As Andy neatly pointed out here: > > https://lore.kernel.org/lkml/20200527133656.GV1634618@smile.fi.intel.co= m/ > > (1 << 31) is UB. >=20 > Thanks, Serge. Yes, we have to use 1U in the definitions (for 31 is > necessary, for the rest is for the sake of consistency). Joel, I know it seems trivial, but I'm a bit flat out right now. Can you please resend with the 1U fix applied. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --zYo4Elh1vtcYNvbq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAl7Yn2gACgkQbDjKyiDZ s5Ko2A/9EOz5F+OpHM6Hm/PfSqeuTj9ieOtOrCEsi0IDwfYm/dzM9guvfG+vwkrT 2czUMP6/43KnMagvyA3aUlWZIFSNb1+clF24ugP5JWZB8rGnzNgCbfNXRmDiS03C eATNtJuGeDR6b+o2pmn72go3cnJlBVJYfXJTuaue7YWVNR+LLZR0/QVne77+BQ7H 7Ca0FCMJv6tBGjqTP1ImBeqFvLWaaHwJOcg5VkTVldzjHYB5nmHWvYkoIuqIu4Ld Cw5qJ+L10+eLb+dcVnn6OBkRiLMFQZ/wVHMQoCjv06nLGaJCaAULy1A7kzweVQnT NDJOUnX0hoTPb/1Q6PYd+ecn5oMxrs9KDS8KYxzRSRdMyet4u+G0ikZRQwjXYeHj RKa82UaKQVYx4ePRyxxwClOobHT8KA3Ra7LAmK5Q6lyI1aHt7OlzW7y+XnDHrUNX 4Ov/KKTCiL9HUaHxr06f389p+EVWf5kOLe586bMFhx8Dp3EFMEa5ITyOSqyp1b0d yOsmWe15AYnKHOsJtzN1Ln8IXsTO1HtWpBOrSPFK/FKO4A1DyKycVsNvuGNB+i2t xppu7se6M8CQEu/ZfJXqgqRwKkvSm7lTcn+a2n3cmdKAgvOdLDLlul/yu4fc2PqY sWD3XaoXpVIaqrptnZW8h4KC5SEPa42W8vgLyIwZib9cccp8oBs= =F2/h -----END PGP SIGNATURE----- --zYo4Elh1vtcYNvbq--