From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47C42C433E0 for ; Thu, 4 Jun 2020 09:05:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F2D82065C for ; Thu, 4 Jun 2020 09:05:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728368AbgFDJFY (ORCPT ); Thu, 4 Jun 2020 05:05:24 -0400 Received: from mga03.intel.com ([134.134.136.65]:17895 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726664AbgFDJFW (ORCPT ); Thu, 4 Jun 2020 05:05:22 -0400 IronPort-SDR: BkG9audbXH0Q7wDp9MGIArZWnhRhMsVX2J7xviMCdUpeJjwl4b1QJC9QhQUZ+wo+AqOj+YGXxi 56+JQfpUaCfw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2020 02:05:20 -0700 IronPort-SDR: lGWk+CCUCdOR70V4sjK0oQFGaloxTVzUi5nUADrIKYP+gEPX0IEIgsg1wyHyEChiyyFFEZLdIQ EVBzvpSpMRCw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,471,1583222400"; d="scan'208";a="294264505" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.141]) by fmsmga004.fm.intel.com with ESMTP; 04 Jun 2020 02:05:17 -0700 Date: Thu, 4 Jun 2020 17:01:50 +0800 From: Xu Yilun To: mfd@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Cc: trix@redhat.com, bhu@redhat.com, mtosatti@redhat.com, gregkh@linuxfoundation.org Subject: Re: [PATCH v6 0/7] Add interrupt support to FPGA DFL drivers Message-ID: <20200604090150.GA15317@yilunxu-OptiPlex-7050> References: <1591260388-15128-1-git-send-email-yilun.xu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1591260388-15128-1-git-send-email-yilun.xu@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I misspelled Moritz's mail address. I'll resent the patchset. Please ignore this set. Sorry for inconvenience. On Thu, Jun 04, 2020 at 04:46:21PM +0800, Xu Yilun wrote: > This patchset add interrupt support to FPGA DFL drivers. > > With these patches, DFL driver will parse and assign interrupt resources > for enumerated feature devices and their sub features. > > This patchset also introduces a set of APIs for user to monitor DFL > interrupts. Three sub features (DFL FME error, DFL AFU error and user > interrupt) drivers now support these APIs. > > Patch #1: DFL framework change. Accept interrupt info input from DFL bus > driver, and add interrupt parsing and assignment for feature > sub devices. > Patch #2: DFL pci driver change, add interrupt info on DFL enumeration. > Patch #3: DFL framework change. Add helper functions for feature sub > device drivers to handle interrupt and notify users. > Patch #4: Add interrupt support for AFU error reporting sub feature. > Patch #5: Add interrupt support for FME global error reporting sub > feature. > Patch #6: Add interrupt support for a new sub feature, to handle user > interrupts implemented in AFU. > Patch #7: Documentation for DFL interrupt handling. > > Main changes from v1: > - Early validating irq table for each feature in parse_feature_irq() > in Patch #1. > - Changes IOCTL interfaces. use DFL_FPGA_FME/PORT_XXX_GET_IRQ_NUM > instead of DFL_FPGA_FME/PORT_XXX_GET_INFO, delete flag field for > DFL_FPGA_FME/PORT_XXX_SET_IRQ param > > Main changes from v2: > - put parse_feature_irqs() inside create_feature_instance(). > - refines code for dfl_fpga_set_irq_triggers, delete local variable j. > - put_user() instead of copy_to_user() for DFL_FPGA_XXX_GET_IRQ_NUM IOCTL > > Main changes from v3: > - rebased to 5.7-rc1. > - fail the dfl enumeration when irq parsing error happens. > - Add 2 helper functions in dfl.c to handle generic irq ioctls in feature > drivers. > > Main changes from v4: > - Minor fixes for Hao's comments. > > Main changes from v5: > - Remove unnecessary type casting in Patch #1 & #3. > - Minor fixes for Moritz's comments. > > Xu Yilun (7): > fpga: dfl: parse interrupt info for feature devices on enumeration > fpga: dfl: pci: add irq info for feature devices enumeration > fpga: dfl: introduce interrupt trigger setting API > fpga: dfl: afu: add interrupt support for port error reporting > fpga: dfl: fme: add interrupt support for global error reporting > fpga: dfl: afu: add AFU interrupt support > Documentation: fpga: dfl: add descriptions for interrupt related > interfaces. > > Documentation/fpga/dfl.rst | 19 +++ > drivers/fpga/dfl-afu-error.c | 17 +++ > drivers/fpga/dfl-afu-main.c | 32 +++++ > drivers/fpga/dfl-fme-error.c | 18 +++ > drivers/fpga/dfl-fme-main.c | 6 + > drivers/fpga/dfl-pci.c | 81 +++++++++-- > drivers/fpga/dfl.c | 308 ++++++++++++++++++++++++++++++++++++++++++ > drivers/fpga/dfl.h | 57 ++++++++ > include/uapi/linux/fpga-dfl.h | 82 +++++++++++ > 9 files changed, 611 insertions(+), 9 deletions(-) > > -- > 2.7.4