From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DC61C433DF for ; Thu, 4 Jun 2020 09:51:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EA012074B for ; Thu, 4 Jun 2020 09:51:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728259AbgFDJvw (ORCPT ); Thu, 4 Jun 2020 05:51:52 -0400 Received: from retiisi.org.uk ([95.216.213.190]:57294 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726711AbgFDJvw (ORCPT ); Thu, 4 Jun 2020 05:51:52 -0400 Received: from valkosipuli.localdomain (valkosipuli.retiisi.org.uk [IPv6:2a01:4f9:c010:4572::80:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 818B1634C87; Thu, 4 Jun 2020 12:50:26 +0300 (EEST) Received: from sailus by valkosipuli.localdomain with local (Exim 4.92) (envelope-from ) id 1jgmW2-00041I-Ke; Thu, 04 Jun 2020 12:50:26 +0300 Date: Thu, 4 Jun 2020 12:50:26 +0300 From: Sakari Ailus To: Laurent Pinchart Cc: Chuhong Yuan , Mauro Carvalho Chehab , Ilkka Myllyperkio , "Ivan T . Ivanov" , Vimarsh Zutshi , Stanimir Varbanov , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] media: omap3isp: Add missed v4l2_ctrl_handler_free() for preview_init_entities() Message-ID: <20200604095026.GI9947@valkosipuli.retiisi.org.uk> References: <20200603164122.2101162-1-hslester96@gmail.com> <20200604093321.GE5829@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200604093321.GE5829@pendragon.ideasonboard.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 04, 2020 at 12:33:21PM +0300, Laurent Pinchart wrote: > Hi Chuhong, > > (CC'ing Sakari Ailus) > > Thank you for the patch. > > On Thu, Jun 04, 2020 at 12:41:22AM +0800, Chuhong Yuan wrote: > > preview_init_entities() does not call v4l2_ctrl_handler_free() when > > it fails. > > Add the missed function to fix it. > > > > Fixes: de1135d44f4f ("[media] omap3isp: CCDC, preview engine and resizer]") > > There's an extra ']' at the end. Apart from that, > > Reviewed-by: Laurent Pinchart > > Sakari, could you take this patch ? Done; thank you! -- Sakari Ailus