From: Mark Brown <broonie@kernel.org>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Keerthy <j-keerthy@ti.com>,
Axel Lin <axel.lin@ingics.com>
Subject: Re: [RFC 1/4] regulator: lp87565: enable voltage regardless of ENx pin
Date: Thu, 4 Jun 2020 12:07:59 +0100 [thread overview]
Message-ID: <20200604110759.GB6644@sirena.org.uk> (raw)
In-Reply-To: <20200603200319.16184-2-luca@lucaceresoli.net>
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On Wed, Jun 03, 2020 at 10:03:16PM +0200, Luca Ceresoli wrote:
> I suspect the only solution that allows to configure the EN_PIN_CTRLn bits
> correctly in all the possible hardware setups would be to tell in device
> tree / board info whether each enable pin is connected or not (which is a
> hardware _fact_) and which ENx pin should control which regulator output
> (which is a policy). But it would make this simple driver considerably more
> complex.
> Any suggestion about the correct way to handle this situation would be
> greatly appreciated.
We can tell if we've got a software controlled GPIO connected, if we
have then we should ensure that it continues to take effect. That
should just be a single register write at startup from the sounds of it.
Otherwise yeah, just ignoring that there's a possibility of a GPIO we
don't know about seems sensible.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-04 11:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 20:03 [RFC 0/4] regulator: lp87565: ignore ENx pins and add LP87524-Q1 Luca Ceresoli
2020-06-03 20:03 ` [RFC 1/4] regulator: lp87565: enable voltage regardless of ENx pin Luca Ceresoli
2020-06-04 11:07 ` Mark Brown [this message]
2020-06-05 7:57 ` Luca Ceresoli
2020-06-03 20:03 ` [RFC 2/4] regulator: lp87565: dt: remove duplicated section Luca Ceresoli
2020-06-04 6:47 ` Lee Jones
2020-06-04 6:48 ` Lee Jones
2020-06-04 8:44 ` Luca Ceresoli
2020-06-12 22:19 ` Rob Herring
2020-06-14 20:00 ` Luca Ceresoli
2020-06-15 0:54 ` J, KEERTHY
2020-06-03 20:03 ` [RFC 3/4] regulator: lp87565: dt: add LP87524-Q1 variant Luca Ceresoli
2020-06-04 6:01 ` Lee Jones
2020-06-04 8:44 ` Luca Ceresoli
2020-06-03 20:03 ` [RFC 4/4] regulator: lp87565: " Luca Ceresoli
2020-06-04 6:44 ` Lee Jones
2020-06-04 8:52 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604110759.GB6644@sirena.org.uk \
--to=broonie@kernel.org \
--cc=axel.lin@ingics.com \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®